From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46154)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Andre.Przywara@amd.com>) id 1QcDp9-0001oq-RQ
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 05:46:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Andre.Przywara@amd.com>) id 1QcDp7-00005f-5N
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 05:46:14 -0400
Received: from am1ehsobe002.messaging.microsoft.com ([213.199.154.205]:27744
	helo=AM1EHSOBE002.bigfish.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Andre.Przywara@amd.com>) id 1QcDp6-00005Q-M6
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 05:46:12 -0400
Message-ID: <4E0C3E5F.4010507@amd.com>
Date: Thu, 30 Jun 2011 11:14:07 +0200
From: Andre Przywara <andre.przywara@amd.com>
MIME-Version: 1.0
References: <1309404579-32115-1-git-send-email-levinsasha928@gmail.com>
In-Reply-To: <1309404579-32115-1-git-send-email-levinsasha928@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH resend] vl.c: Don't limit node count by smp
 count
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Sasha Levin <levinsasha928@gmail.com>

On 06/30/2011 05:29 AM, Sasha Levin wrote:
> [I've sent this patch couple of months ago and noticed it
>   didn't make it's way in - so I'm sending it again]
>
> It is possible to create CPU-less NUMA nodes, node amount shouldn't be
> limited by amount of CPUs.
>
> Tested-by: Michael Roth<mdroth@linux.vnet.ibm.com>
> Signed-off-by: Sasha Levin<levinsasha928@gmail.com>
> ---
>   vl.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index e0191e1..b95ae8d 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3147,8 +3147,8 @@ int main(int argc, char **argv, char **envp)
>       if (nb_numa_nodes>  0) {
>           int i;
>
> -        if (nb_numa_nodes>  smp_cpus) {
> -            nb_numa_nodes = smp_cpus;
> +        if (nb_numa_nodes>  MAX_NODES) {
> +            nb_numa_nodes = MAX_NODES;
>           }
>
>           /* If no memory size if given for any node, assume the default case

Acked-by: Andre Przywara <andre.przywara@amd.com>

Regards,
Andre.


-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany