From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcFGs-0006HT-1C for qemu-devel@nongnu.org; Thu, 30 Jun 2011 07:18:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcFGp-0006lg-Tf for qemu-devel@nongnu.org; Thu, 30 Jun 2011 07:18:57 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36992 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcFGp-0006lY-KF for qemu-devel@nongnu.org; Thu, 30 Jun 2011 07:18:55 -0400 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id C55548A95F for ; Thu, 30 Jun 2011 13:18:54 +0200 (CEST) Message-ID: <4E0C5B9E.9070809@suse.de> Date: Thu, 30 Jun 2011 13:18:54 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1309417722-11424-1-git-send-email-cyliu@novell.com> <58A6676B-5E1B-49E9-B315-E84C46D2E1D1@suse.de> <201106301739.59597.cyliu@novell.com> In-Reply-To: <201106301739.59597.cyliu@novell.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3] Support logging xen-guest console List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chun Yan Liu Cc: qemu-devel@nongnu.org On 06/30/2011 11:39 AM, Chun Yan Liu wrote: > On Thursday, June 30, 2011 03:58:57 PM Alexander Graf wrote: >> On 30.06.2011, at 09:08, Chunyan Liu wrote: >>> Add code to support logging xen-domU console, as what xenconsoled does. >>> To enable logging, set environment variable XENCONSOLED_TRACE=guest and >>> XENCONSOLED_LOGDIR=, log file will be saved in >>> . >> In fact, this whole thing looks as if you're merely trying to reimplement >> "tee" on the xenconsole output. Wouldn't it make more sense to do this in >> the char layer? So we could do: >> >> -xenconsole tee:stdio,file:/tmp/xen.log >> >> or similar? That's probably a lot more useful than a random Xen specific >> hack. >> > Thanks, Alex. It IS something like "tee". But IMO, change in xen_console.c > and change in char layer are just different time points, do not have essential > difference. Change in xen_console.c is trying to backup output data into log > file before sending to char device, change in char device is trying to > dupicate data from char device to log file. Correct me if I'm wrong. Sure, the outcome is the same though, no? We get the output data in both a file and the char backend. Alex