From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcFWF-0000MM-2M for qemu-devel@nongnu.org; Thu, 30 Jun 2011 07:34:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcFWD-0001Ce-7H for qemu-devel@nongnu.org; Thu, 30 Jun 2011 07:34:50 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38376 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcFWC-0001CY-T0 for qemu-devel@nongnu.org; Thu, 30 Jun 2011 07:34:49 -0400 Message-ID: <4E0C5F57.4060408@suse.de> Date: Thu, 30 Jun 2011 13:34:47 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1308758311-32692-1-git-send-email-anthony.perard@citrix.com> In-Reply-To: <1308758311-32692-1-git-send-email-anthony.perard@citrix.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony.perard@citrix.com Cc: Xen Devel , QEMU-devel , Stefano Stabellini On 06/22/2011 05:58 PM, anthony.perard@citrix.com wrote: > From: Anthony PERARD > > Signed-off-by: Anthony PERARD > --- > hw/piix_pci.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/hw/piix_pci.c b/hw/piix_pci.c > index 26ce904..d08b31a 100644 > --- a/hw/piix_pci.c > +++ b/hw/piix_pci.c > @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = { > .no_hotplug = 1, > .init = piix3_initfn, > .config_write = piix3_write_config_xen, > + .vendor_id = PCI_VENDOR_ID_INTEL, > + .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1) > + .class_id = PCI_CLASS_BRIDGE_ISA, > },{ > /* end of list */ > } $ ./scripts/checkpatch.pl ~/patch-xen/anthony1/\[PATCH\]\ hw_piix_pci.c\:\ Fix\ PIIX3-xen\ to\ initialize\ ids.eml WARNING: line over 80 characters #70: FILE: hw/piix_pci.c:482: + .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1) ERROR: do not use C99 // comments #70: FILE: hw/piix_pci.c:482: + .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1) total: 1 errors, 1 warnings, 9 lines checked From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids Date: Thu, 30 Jun 2011 13:34:47 +0200 Message-ID: <4E0C5F57.4060408@suse.de> References: <1308758311-32692-1-git-send-email-anthony.perard@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1308758311-32692-1-git-send-email-anthony.perard@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: anthony.perard@citrix.com Cc: Xen Devel , QEMU-devel , Anthony Liguori , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 06/22/2011 05:58 PM, anthony.perard@citrix.com wrote: > From: Anthony PERARD > > Signed-off-by: Anthony PERARD > --- > hw/piix_pci.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/hw/piix_pci.c b/hw/piix_pci.c > index 26ce904..d08b31a 100644 > --- a/hw/piix_pci.c > +++ b/hw/piix_pci.c > @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = { > .no_hotplug = 1, > .init = piix3_initfn, > .config_write = piix3_write_config_xen, > + .vendor_id = PCI_VENDOR_ID_INTEL, > + .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1) > + .class_id = PCI_CLASS_BRIDGE_ISA, > },{ > /* end of list */ > } $ ./scripts/checkpatch.pl ~/patch-xen/anthony1/\[PATCH\]\ hw_piix_pci.c\:\ Fix\ PIIX3-xen\ to\ initialize\ ids.eml WARNING: line over 80 characters #70: FILE: hw/piix_pci.c:482: + .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1) ERROR: do not use C99 // comments #70: FILE: hw/piix_pci.c:482: + .device_id = PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 PCI-to-ISA bridge (Step A1) total: 1 errors, 1 warnings, 9 lines checked