From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcIOq-0004LS-Ny for qemu-devel@nongnu.org; Thu, 30 Jun 2011 10:39:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QcIOp-0003FK-54 for qemu-devel@nongnu.org; Thu, 30 Jun 2011 10:39:24 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51365 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QcIOo-0003FE-SN for qemu-devel@nongnu.org; Thu, 30 Jun 2011 10:39:23 -0400 Message-ID: <4E0C8A99.7020705@suse.de> Date: Thu, 30 Jun 2011 16:39:21 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1309345967-14397-1-git-send-email-stefano.stabellini@eu.citrix.com> In-Reply-To: <1309345967-14397-1-git-send-email-stefano.stabellini@eu.citrix.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3] xen_console: support the new extended xenstore protocol List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: stefano.stabellini@eu.citrix.com Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, qemu-devel@nongnu.org On 06/29/2011 01:12 PM, stefano.stabellini@eu.citrix.com wrote: > From: Stefano Stabellini > > Since CS 21994 on xen-unstable.hg and CS > 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few > changes have been introduced to the PV console xenstore protocol, as > described by the document docs/misc/console.txt under xen-unstable.hg. > > From the Qemu point of view, very few modifications are needed to > correctly support the protocol: read from xenstore the "output" node > that tell us what the output of the PV console is going to be. > In case the output is a tty, write to xenstore the device name. > > Changes in v2: > > - fix error paths: free malloc'ed strings and close the xenstore > connection before returning; > > - remove useless snprintf in xenstore_store_pv_console_info if i =3D=3D= 0. > > Changes in v3: > > - replace xs_daemon_open/xs_daemon_close with xs_open/xs_close. On SLES11SP1: cc1: warnings being treated as errors /studio/tmp/agraf/xen-all.c: In function =91store_dev_info=92: /studio/tmp/agraf/xen-all.c:755: error: implicit declaration of function=20 =91xs_open=92 /studio/tmp/agraf/xen-all.c:755: error: nested extern declaration of=20 =91xs_open=92 /studio/tmp/agraf/xen-all.c:755: error: assignment makes pointer from=20 integer without a cast /studio/tmp/agraf/xen-all.c:784: error: implicit declaration of function=20 =91xs_close=92 /studio/tmp/agraf/xen-all.c:784: error: nested extern declaration of=20 =91xs_close=92 Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH v3] xen_console: support the new extended xenstore protocol Date: Thu, 30 Jun 2011 16:39:21 +0200 Message-ID: <4E0C8A99.7020705@suse.de> References: <1309345967-14397-1-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1309345967-14397-1-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: stefano.stabellini@eu.citrix.com Cc: peter.maydell@linaro.org, xen-devel@lists.xensource.com, qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org On 06/29/2011 01:12 PM, stefano.stabellini@eu.citrix.com wrote: > From: Stefano Stabellini > > Since CS 21994 on xen-unstable.hg and CS > 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few > changes have been introduced to the PV console xenstore protocol, as > described by the document docs/misc/console.txt under xen-unstable.hg. > > From the Qemu point of view, very few modifications are needed to > correctly support the protocol: read from xenstore the "output" node > that tell us what the output of the PV console is going to be. > In case the output is a tty, write to xenstore the device name. > > Changes in v2: > > - fix error paths: free malloc'ed strings and close the xenstore > connection before returning; > > - remove useless snprintf in xenstore_store_pv_console_info if i =3D=3D= 0. > > Changes in v3: > > - replace xs_daemon_open/xs_daemon_close with xs_open/xs_close. On SLES11SP1: cc1: warnings being treated as errors /studio/tmp/agraf/xen-all.c: In function =91store_dev_info=92: /studio/tmp/agraf/xen-all.c:755: error: implicit declaration of function=20 =91xs_open=92 /studio/tmp/agraf/xen-all.c:755: error: nested extern declaration of=20 =91xs_open=92 /studio/tmp/agraf/xen-all.c:755: error: assignment makes pointer from=20 integer without a cast /studio/tmp/agraf/xen-all.c:784: error: implicit declaration of function=20 =91xs_close=92 /studio/tmp/agraf/xen-all.c:784: error: nested extern declaration of=20 =91xs_close=92 Alex