From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44797)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1QcItc-0004dn-Vi
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 11:11:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1QcItX-0000MZ-FK
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 11:11:12 -0400
Received: from cantor2.suse.de ([195.135.220.15]:53755 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1QcItX-0000MH-2K
	for qemu-devel@nongnu.org; Thu, 30 Jun 2011 11:11:07 -0400
Message-ID: <4E0C920A.8030308@suse.de>
Date: Thu, 30 Jun 2011 17:11:06 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1309187401-27685-1-git-send-email-stefano.stabellini@eu.citrix.com>
In-Reply-To: <1309187401-27685-1-git-send-email-stefano.stabellini@eu.citrix.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] xen_disk: cope with missing xenstore
	"params" node
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: stefano.stabellini@eu.citrix.com
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org

On 06/27/2011 05:10 PM, stefano.stabellini@eu.citrix.com wrote:
> From: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>
> When disk is a cdrom and the drive is empty the "params" node in
> xenstore might be missing completely: cope with it instead of
> segfaulting.
>
>
> Updated in v2:
>
> - actually removed the strchr(blkdev->params, ':') that caused the
> segfault;
>
> - free all the allocated strings from xenstore before returning;
>
>
> Updated in v3:
>
> - set blkdev fields to NULL after free'ing them.

Thanks, applied to xen-next branch.


Alex

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH v3] xen_disk: cope with missing xenstore
	"params" node
Date: Thu, 30 Jun 2011 17:11:06 +0200
Message-ID: <4E0C920A.8030308@suse.de>
References: <1309187401-27685-1-git-send-email-stefano.stabellini@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1309187401-27685-1-git-send-email-stefano.stabellini@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: stefano.stabellini@eu.citrix.com
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org
List-Id: xen-devel@lists.xenproject.org

On 06/27/2011 05:10 PM, stefano.stabellini@eu.citrix.com wrote:
> From: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>
> When disk is a cdrom and the drive is empty the "params" node in
> xenstore might be missing completely: cope with it instead of
> segfaulting.
>
>
> Updated in v2:
>
> - actually removed the strchr(blkdev->params, ':') that caused the
> segfault;
>
> - free all the allocated strings from xenstore before returning;
>
>
> Updated in v3:
>
> - set blkdev fields to NULL after free'ing them.

Thanks, applied to xen-next branch.


Alex