From: Glauber Costa <glommer@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Rik van Riel <riel@redhat.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Avi Kivity <avi@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
Eric B Munson <emunson@mgebm.net>
Subject: Re: [PATCH v3 7/9] KVM-GST: KVM Steal time accounting
Date: Thu, 30 Jun 2011 23:50:58 -0300 [thread overview]
Message-ID: <4E0D3612.6040701@redhat.com> (raw)
In-Reply-To: <1309470871.12449.608.camel@twins>
On 06/30/2011 06:54 PM, Peter Zijlstra wrote:
> On Wed, 2011-06-29 at 11:29 -0400, Glauber Costa wrote:
>> This patch accounts steal time time in kernel/sched.
>> I kept it from last proposal, because I still see advantages
>> in it: Doing it here will give us easier access from scheduler
>> variables such as the cpu rq. The next patch shows an example of
>> usage for it.
>>
>> Since functions like account_idle_time() can be called from
>> multiple places, not only account_process_tick(), steal time
>> grabbing is repeated in each account function separatedely.
>>
>
> That changelog is so going to frustrate someone trying to re-create your
> thinking in a year's time. They really don't care about the last
> proposals and the next patch.
You're right. I'll review all changelogs and rewrite them as needed.
next prev parent reply other threads:[~2011-07-01 2:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 15:29 [PATCH v3 0/9] Steal time for KVM Glauber Costa
2011-06-29 15:29 ` [PATCH v3 1/9] introduce kvm_read_guest_cached Glauber Costa
2011-06-29 15:29 ` [PATCH v3 2/9] KVM-HDR Add constant to represent KVM MSRs enabled bit Glauber Costa
2011-06-29 21:56 ` Eric B Munson
2011-06-30 8:31 ` Avi Kivity
2011-06-30 12:59 ` Eric B Munson
2011-06-30 13:21 ` Glauber Costa
2011-06-30 14:13 ` Eric B Munson
2011-06-29 15:29 ` [PATCH v3 3/9] KVM-HDR: KVM Steal time implementation Glauber Costa
2011-06-29 21:56 ` Eric B Munson
2011-06-30 21:54 ` Peter Zijlstra
2011-06-29 15:29 ` [PATCH v3 4/9] KVM-HV: " Glauber Costa
2011-06-29 21:56 ` Eric B Munson
2011-06-29 15:29 ` [PATCH v3 5/9] KVM-HV: use schedstats to calculate steal time Glauber Costa
2011-06-29 21:56 ` Eric B Munson
2011-06-29 15:29 ` [PATCH v3 6/9] KVM-GST: Add a pv_ops stub for " Glauber Costa
2011-06-29 21:56 ` Eric B Munson
2011-06-29 15:29 ` [PATCH v3 7/9] KVM-GST: KVM Steal time accounting Glauber Costa
2011-06-29 21:57 ` Eric B Munson
2011-06-30 21:54 ` Peter Zijlstra
2011-07-01 2:53 ` Glauber Costa
2011-07-01 8:26 ` Peter Zijlstra
2011-06-30 21:54 ` Peter Zijlstra
2011-07-01 2:50 ` Glauber Costa [this message]
2011-06-30 21:54 ` Peter Zijlstra
2011-07-01 2:50 ` Glauber Costa
2011-07-01 8:25 ` Peter Zijlstra
2011-06-30 21:54 ` Peter Zijlstra
2011-06-29 15:29 ` [PATCH v3 8/9] KVM-GST: adjust scheduler cpu power Glauber Costa
2011-06-29 21:57 ` Eric B Munson
2011-06-30 21:54 ` Peter Zijlstra
2011-06-30 21:54 ` Peter Zijlstra
2011-06-30 21:54 ` Peter Zijlstra
2011-06-29 15:29 ` [PATCH v3 9/9] KVM-GST: KVM Steal time registration Glauber Costa
2011-06-29 21:57 ` Eric B Munson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0D3612.6040701@redhat.com \
--to=glommer@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=emunson@mgebm.net \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.