All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 1/4] add support for machine models to specify their migration format
Date: Fri, 01 Jul 2011 08:10:22 +0200	[thread overview]
Message-ID: <4E0D64CE.40509@redhat.com> (raw)
In-Reply-To: <20110630181110.GA11924@redhat.com>

On 06/30/2011 08:11 PM, Michael S. Tsirkin wrote:
> >  Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>
> Should not machine describe guest behaviour?
> It seems that a flag to the migrate/save command to control format
> would be better - this way the same machine can
> migrate to different formats.

I thought about it, but there is no savevm state variable (only 
migration state, but it's unused for snapshotting).  So it seemed too 
much work for an RFC series I wanted to push out fast.

Besides, you need to store a default somewhere, and the default must be 
the old format for versioned machine models; perhaps not from QEMU where 
new->old migration is a wild bet anyway, but for downstream it must. 
Then I think that you are suggesting a superset of this patch. I'm not 
even sure it is necessary to have it though: it is a correctness fix, it 
should be on for everyone.

Paolo

  reply	other threads:[~2011-07-01  6:10 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-30 15:46 [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format Paolo Bonzini
2011-06-30 15:46 ` [Qemu-devel] [RFC PATCH 1/4] add support for machine models to specify their " Paolo Bonzini
2011-06-30 18:11   ` Michael S. Tsirkin
2011-07-01  6:10     ` Paolo Bonzini [this message]
2011-07-29 13:08   ` Anthony Liguori
2011-07-29 14:35     ` Paolo Bonzini
2011-06-30 15:46 ` [Qemu-devel] [RFC PATCH 2/4] add pc-0.14 machine Paolo Bonzini
2011-08-05 19:26   ` Bruce Rogers
2011-08-05 19:41     ` Anthony Liguori
2011-06-30 15:46 ` [Qemu-devel] [RFC PATCH 3/4] savevm: define new unambiguous migration format Paolo Bonzini
2011-07-29 13:12   ` Anthony Liguori
2011-07-29 14:35     ` Paolo Bonzini
2011-06-30 15:46 ` [Qemu-devel] [RFC PATCH 4/4] Partially revert "savevm: fix corruption in vmstate_subsection_load()." Paolo Bonzini
2011-07-25 21:10 ` [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format Paolo Bonzini
2011-07-25 23:23   ` Anthony Liguori
2011-07-26  9:42     ` Daniel P. Berrange
2011-07-26  9:48     ` Stefan Hajnoczi
2011-07-26 12:51       ` Stefan Hajnoczi
2011-07-26 13:00         ` Anthony Liguori
2011-07-26 12:07     ` Juan Quintela
2011-07-26 12:37       ` Anthony Liguori
2011-07-26 20:13         ` Juan Quintela
2011-07-26 21:46           ` Anthony Liguori
2011-07-26 22:22             ` Peter Maydell
2011-07-26 23:08               ` Anthony Liguori
2011-07-29 14:03         ` Kevin Wolf
2011-07-29 14:28           ` Anthony Liguori
2011-07-29 15:18             ` Kevin Wolf
2011-07-29 22:28               ` Anthony Liguori
2011-07-31 10:48                 ` Dor Laor
2011-07-31 11:37                   ` Peter Maydell
2011-07-31 11:45                     ` Dor Laor
2011-07-31 18:46                       ` Christoph Hellwig
2011-07-31 20:43                         ` Dor Laor
2011-07-31 20:55                           ` Anthony Liguori
2011-07-31 23:10                           ` Christoph Hellwig
2011-08-01  0:15                             ` Anthony Liguori
2011-08-01  7:54                               ` Christoph Hellwig
2011-08-01 13:53                                 ` Anthony Liguori
2011-08-04 14:59                                   ` Luiz Capitulino
2011-07-31 20:43                   ` Anthony Liguori
2011-07-31 20:57                     ` Dor Laor
2011-07-31 21:03                       ` Anthony Liguori
2011-07-31 21:25                         ` Dor Laor
2011-07-31 21:49                           ` Anthony Liguori
2011-07-29 13:14   ` Anthony Liguori
2011-07-29 14:49     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0D64CE.40509@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.