From: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org, ldewangan@nvidia.com,
shubhrajyoti@ti.com
Subject: Re: [PATCH 10/25] staging:iio:magnetometer:hmc5843 iio_chan_spec conversion.
Date: Fri, 01 Jul 2011 12:59:13 +0200 [thread overview]
Message-ID: <4E0DA881.30608@iis.fraunhofer.de> (raw)
In-Reply-To: <1309515076-12323-11-git-send-email-jic23@cam.ac.uk>
On 01.07.2011 12:11, Jonathan Cameron wrote:
> -static IIO_DEVICE_ATTR(magn_scale,
> - S_IRUGO,
> - show_scale,
> - NULL , 0);
> +
> +#define HMC5843_CHANNEL(axis, add) \
> + { \
> + .type =3D IIO_MAGN, \
> + .modified =3D 1, \
> + .channel2 =3D IIO_MOD_##axis, \
> + .info_mask =3D (1<< IIO_CHAN_INFO_SCALE_SHARED), \
> + .address =3D add \
> + }
> +
> +static const struct iio_chan_spec hmc5843_channels[] =3D {
> + HMC5843_CHANNEL(X, HMC5843_DATA_OUT_X_MSB_REG),
> + HMC5843_CHANNEL(X, HMC5843_DATA_OUT_Y_MSB_REG),
> + HMC5843_CHANNEL(X, HMC5843_DATA_OUT_Z_MSB_REG),
> +};
Shouldn't be all X, I guess.
Regards,
--=20
Manuel Stahl
Fraunhofer-Institut IIS
Leistungsoptimierte Systeme
Nordostpark 93
D90411 N=FCrnberg
Telefon +49 (0)911/58061-6419
Fax +49 (0)911/58061-6398
E-Mail manuel.stahl@iis.fraunhofer.de
http://www.iis.fraunhofer.de
http://www.smart-power.fraunhofer.de
next prev parent reply other threads:[~2011-07-01 10:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 10:10 [PATCH V2 00/25] staging:iio: move chan_spec conversions and general cleanup Jonathan Cameron
2011-07-01 10:10 ` [PATCH 01/25] staging:iio:accel:kxsd9 cleanup and conversion to iio_chan_spec Jonathan Cameron
2011-07-01 10:10 ` [PATCH 02/25] staging:iio: add quadrature correction to chan info types Jonathan Cameron
2011-07-01 10:10 ` [PATCH 03/25] staging:iio:gyro:adxrs450 move to iio_chan_spec registration Jonathan Cameron
2011-07-01 10:10 ` [PATCH 04/25] staging:iio:gyro:adxrs450 make more use of spi_read and spi_write Jonathan Cameron
2011-07-01 10:10 ` [PATCH 05/25] staging:iio:gyro:adxrs450 squish some trivial single call point wrappers functions Jonathan Cameron
2011-07-01 10:10 ` [PATCH 06/25] staging:iio:gyro:adis16080 convert to iio_chan_spec Jonathan Cameron
2011-07-01 10:10 ` [PATCH 07/25] staging:iio:gyro:adis16260 remove some unused headers Jonathan Cameron
2011-07-01 10:10 ` [PATCH 08/25] staging:iio:imu:adis16400 remove " Jonathan Cameron
2011-07-01 10:11 ` [PATCH 09/25] staging:iio:magnetometer:ak8975 convert to iio_chan_spec + cleanups Jonathan Cameron
2011-07-01 10:11 ` [PATCH 10/25] staging:iio:magnetometer:hmc5843 iio_chan_spec conversion Jonathan Cameron
2011-07-01 10:59 ` Manuel Stahl [this message]
2011-07-01 12:15 ` Jonathan Cameron
2011-07-01 10:11 ` [PATCH 11/25] staging:iio:magnetometer: remove unused header magnet.h Jonathan Cameron
2011-07-01 10:11 ` [PATCH 12/25] staging:iio:gyro:adis16130 fix adis16130_spi_read which was never selecting the channel Jonathan Cameron
2011-07-01 10:11 ` [PATCH 13/25] staging:iio:gyro:adis16130 drop control of adc resolution Jonathan Cameron
2011-07-01 10:11 ` [PATCH 14/25] staging:iio:gyro:adis16130 move to iio_chan_spec registration Jonathan Cameron
2011-07-01 10:11 ` [PATCH 15/25] staging:iio:gyro:adis16060 convert to iio_chan_spec Jonathan Cameron
2011-07-01 10:11 ` [PATCH 16/25] staging:iio:gyro: remove gyro.h Jonathan Cameron
2011-07-01 10:11 ` [PATCH 17/25] staging:iio:accel: usused header removals Jonathan Cameron
2011-07-01 10:11 ` [PATCH 18/25] staging:iio:inclinometer.h remove as now unused Jonathan Cameron
2011-07-01 10:11 ` [PATCH 19/25] staging:iio:adc: unused header removals Jonathan Cameron
2011-07-01 10:11 ` [PATCH 20/25] staging:iio:various header includes that should never have been Jonathan Cameron
2011-07-01 10:11 ` [PATCH 21/25] staging:iio:accel:adis16204: use peak_raw info_mask element + push some defs down from header Jonathan Cameron
2011-07-01 10:11 ` [PATCH 22/25] staging:iio:accel:adis16220 iio_chan_spec conversion Jonathan Cameron
2011-07-01 10:11 ` [PATCH 23/25] staging:iio:accel remove unused accel.h header Jonathan Cameron
2011-07-01 10:11 ` [PATCH 24/25] staging:iio:adc remove unused adc.h Jonathan Cameron
2011-07-01 10:11 ` [PATCH 25/25] staging:iio:gyro:adis16260 fix missing num_channels setup Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0DA881.30608@iis.fraunhofer.de \
--to=manuel.stahl@iis.fraunhofer.de \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=jic23@cam.ac.uk \
--cc=ldewangan@nvidia.com \
--cc=linux-iio@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.