From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Chiappero Subject: Re: [PATCH 12/25] sony-laptop: input core improvements improvements Date: Fri, 01 Jul 2011 16:20:06 +0200 Message-ID: <4E0DD796.1070600@absence.it> References: <20110605222401.GA26835@kamineko.org> <4DECD592.6000707@absence.it> <20110607142332.GA4087@kamineko.org> <4DEE4094.8040300@absence.it> <20110607162413.GC4087@kamineko.org> <4DEE66F5.1020406@absence.it> <4DFF50DB.30100@absence.it> <4E0DAB83.3070406@absence.it> <20110701125020.GA31697@srcf.ucam.org> <4E0DD3AE.1000908@absence.it> <20110701140915.GA1363@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from aa013-1msr.fastwebnet.it ([62.101.93.133]:40455 "EHLO aa013-1msr.fastwebnet.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756598Ab1GAOUI (ORCPT ); Fri, 1 Jul 2011 10:20:08 -0400 In-Reply-To: <20110701140915.GA1363@srcf.ucam.org> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Matthew Garrett Cc: Mattia Dongili , platform-driver-x86@vger.kernel.org Il 01/07/2011 16:09, Matthew Garrett ha scritto: > On Fri, Jul 01, 2011 at 04:03:26PM +0200, Marco Chiappero wrote: >> Il 01/07/2011 14:50, Matthew Garrett ha scritto: >>> We've standardised on doing this via the input layer. >> >> Are you referring to >> KEY_TOUCHPAD_TOGGLE/KEY_TOUCHPAD_ON/KEY_TOUCHPAD_OFF? If so, we end >> up having two different unrelated controls. > > That's what I'm referring to, yes. I don't understand what you mean by > unrelated controls. The hardware stored setting touchpad on/off. The KEY_TOUCHPAD_TOGGLE input key can be used by userspace but how can userspace act on the hardware setting? And if the touchpad is disabled via hardware, pressing the combo will have no effect.