From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH] drm/i915: apply HWSTAM writes to Ivy Bridge as well Date: Fri, 01 Jul 2011 13:01:50 -0700 Message-ID: <4E0E27AE.3040402@whitecape.org> References: <1309543736-2335-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from homiemail-a6.g.dreamhost.com (caiajhbdcaid.dreamhost.com [208.97.132.83]) by gabe.freedesktop.org (Postfix) with ESMTP id 961C69E7A8 for ; Fri, 1 Jul 2011 13:01:51 -0700 (PDT) Received: from homiemail-a6.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a6.g.dreamhost.com (Postfix) with ESMTP id 1B8E459807A for ; Fri, 1 Jul 2011 13:01:51 -0700 (PDT) Received: from [192.168.1.153] (fruit.freedesktop.org [131.252.210.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: kenneth@whitecape.org) by homiemail-a6.g.dreamhost.com (Postfix) with ESMTPSA id E6CDD59807D for ; Fri, 1 Jul 2011 13:01:50 -0700 (PDT) In-Reply-To: <1309543736-2335-1-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 07/01/2011 11:08 AM, Jesse Barnes wrote: > In an attempt to fix 38862 and 38863. > > Signed-off-by: Jesse Barnes Tested-by: Kenneth Graunke Prior to this patch, running the piglit test suite would randomly hang the GPU unless I added msleeps between each test. (Individual tests ran fine.) This patch fixes the issue. I am now able to run piglit unmodified without hanging the GPU. Keith, could this go into -fixes? Thanks for finding this, Chris and Jesse! --Kenneth > --- > drivers/gpu/drm/i915/i915_irq.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index 2e18161..23d1ae6 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -1745,7 +1745,7 @@ static void ironlake_irq_preinstall(struct drm_device *dev) > INIT_WORK(&dev_priv->rps_work, gen6_pm_rps_work); > > I915_WRITE(HWSTAM, 0xeffe); > - if (IS_GEN6(dev)) { > + if (IS_GEN6(dev) || IS_GEN7(dev)) { > /* Workaround stalls observed on Sandy Bridge GPUs by > * making the blitter command streamer generate a > * write to the Hardware Status Page for