Re: r8712u driver for the rtl8192su chip.

[Larry Finger <Larry.Finger@lwfinger.net>]

On 07/02/2011 08:06 PM, Ali Bahar wrote:
> Hi Larry,
>
> On Sat, Jul 02, 2011 at 12:09:08PM -0500, Larry Finger wrote:
>> On 06/27/2011 02:23 AM, Ali Bahar wrote:
>
>>> The cause is that the driver's handler for the Set expects that the
>>> interface is Up. In my case, it was not, and so it returns a -1. This
>>> pops back up the call-chain until it gets misinterpreted as an EPERM.
>
>> The attached patch has been floating around for a while. Does it help?
>
> Of course, it will, but the general problem with the -1 return-values
> (and any other Up assumptions) will remain.
>
> As I'd indicated earlier, I have no interest in, or use for, this
> device. I dug into it because there seemed to be a need within this
> ML (and I was already looking for an 802.11 project anyway.)
>
> If that is the case, I can implement the changes, merge recent Realtek
> changes, and determine how much nl80211 interface is needed.
> On the other hand, if changes are on-hold, then I'll focus elsewhere.
>
> regards,
> ali
>
>
>> Index: linux-2.6/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
>> ===================================================================
>> --- linux-2.6.orig/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
>> +++ linux-2.6/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
>> @@ -990,8 +990,6 @@ static int r8711_wx_set_wap(struct net_d
>>   	struct wlan_network *pnetwork = NULL;
>>   	enum NDIS_802_11_AUTHENTICATION_MODE	authmode;
>>
>> -	if (padapter->bup == false)
>> -		return -1;
>>   	if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) == true)
>>   		return -1;
>>   	if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) == true)
>> @@ -1182,8 +1180,6 @@ static int r8711_wx_set_essid(struct net
>>   	struct list_head *phead;
>>   	u32 len;
>>
>> -	if (padapter->bup == false)
>> -		return -1;
>>   	if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY))
>>   		return -1;
>>   	if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING))

If you want to work on it, I will review and test the patches. It will be a long 
time until I get to it.

Larry