From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, TeLeMan <geleman@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp
Date: Sun, 03 Jul 2011 16:09:01 +0200 [thread overview]
Message-ID: <4E1077FD.9050001@redhat.com> (raw)
In-Reply-To: <4E0EE837.1000605@web.de>
On 07/02/2011 11:43 AM, Jan Kiszka wrote:
> static const char *pch;
> +static char *saved_key;
> static jmp_buf expr_env;
>
> #define MD_TLONG 0
> @@ -4254,8 +4255,11 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon,
> }
> typestr++;
> }
> - if (get_expr(mon,&val,&p))
> + saved_key = key;
> + if (get_expr(mon,&val,&p)) {
> + key = saved_key;
> goto fail;
> + }
Please make saved_key a volatile local instead.
Paolo
next prev parent reply other threads:[~2011-07-03 14:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 16:47 [Qemu-devel] "cpu-exec.c: avoid AREG0 use" breaks x86 emulation on x86-64 Jan Kiszka
2011-06-30 21:17 ` Stefan Weil
2011-07-01 1:44 ` TeLeMan
2011-07-01 20:15 ` Blue Swirl
2011-07-02 7:50 ` [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp Jan Kiszka
2011-07-02 9:08 ` Blue Swirl
2011-07-02 9:43 ` Jan Kiszka
2011-07-03 14:09 ` Paolo Bonzini [this message]
2011-07-12 20:56 ` Blue Swirl
2011-08-11 11:30 ` Peter Maydell
2011-08-11 12:16 ` Paolo Bonzini
2011-08-11 12:40 ` Peter Maydell
2011-08-11 13:13 ` Paolo Bonzini
2011-08-11 13:31 ` Peter Maydell
2011-08-11 14:10 ` Paolo Bonzini
2011-08-11 14:12 ` David Gilbert
2011-08-11 14:24 ` Peter Maydell
2011-08-11 14:32 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1077FD.9050001@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=geleman@gmail.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.