All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Yonit Halperin <yhalperi@redhat.com>
Cc: spice-devel@lists.freedesktop.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2] qxl: make sure primary surface is saved on migration
Date: Mon, 04 Jul 2011 13:44:43 +0200	[thread overview]
Message-ID: <4E11A7AB.6080401@redhat.com> (raw)
In-Reply-To: <1309779051-26370-1-git-send-email-yhalperi@redhat.com>

   Hi,

> +        qxl_set_dirty(devram_addr, devram_addr + qxl->rom->surface0_area_size);

s/rom/shadow_rom/, then it is perfect.  rom points directly to guest 
memory, better don't trust that.

cheers,
   Gerd

      reply	other threads:[~2011-07-04 11:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04 11:30 [Qemu-devel] [PATCHv2] qxl: make sure primary surface is saved on migration Yonit Halperin
2011-07-04 11:44 ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E11A7AB.6080401@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=spice-devel@lists.freedesktop.org \
    --cc=yhalperi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.