All of lore.kernel.org
 help / color / mirror / Atom feed
From: Iiro Valkonen <iiro.valkonen@atmel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/3] Input: atmel_mxt_ts - Make wait-after-reset period compatible with all chips
Date: Mon, 04 Jul 2011 15:42:55 +0300	[thread overview]
Message-ID: <4E11B54F.3010702@atmel.com> (raw)
In-Reply-To: <20110704100435.GA3723@core.coreip.homeip.net>

On 07/04/2011 01:04 PM, Dmitry Torokhov wrote:
>>  
>> @@ -828,6 +828,8 @@ static int mxt_initialize(struct mxt_data *data)
>>  	mxt_write_object(data, MXT_GEN_COMMAND,
>>  			MXT_COMMAND_RESET, 1);
>>  	msleep(MXT_RESET_TIME);
>> +	while (data->pdata->read_chg())
>> +		msleep(2);
> 
> I would prefer if we did not wait indefinitely but timed out after
> certain number of retries.
> 

Thanks, that does make sense. I'll send a new version.


BR,

-- 
Iiro

      reply	other threads:[~2011-07-04 12:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04  9:05 [PATCH 1/3] Input: atmel_mxt_ts - Make wait-after-reset period compatible with all chips Iiro Valkonen
2011-07-04 10:04 ` Dmitry Torokhov
2011-07-04 12:42   ` Iiro Valkonen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E11B54F.3010702@atmel.com \
    --to=iiro.valkonen@atmel.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jy0922.shim@samsung.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.