From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH 3/3] megasas: LSI Megaraid SAS emulation Date: Mon, 04 Jul 2011 14:52:52 +0200 Message-ID: <4E11B7A4.8030807@suse.de> References: <1309534555-22178-1-git-send-email-hare@suse.de> <1309534555-22178-2-git-send-email-hare@suse.de> <1309534555-22178-3-git-send-email-hare@suse.de> <1309534555-22178-4-git-send-email-hare@suse.de> <4E0F2215.4040307@suse.de> <4E107E66.3030001@redhat.com> <4E115A21.8010003@suse.de> <4E115EFD.7020607@redhat.com> <4E116B32.702@suse.de> <4E119622.1030709@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Alexander Graf , qemu-devel@nongnu.org, Stefan Haynoczi , "kvm@vger.kernel.org" To: Paolo Bonzini Return-path: Received: from cantor2.suse.de ([195.135.220.15]:51974 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753459Ab1GDMw4 (ORCPT ); Mon, 4 Jul 2011 08:52:56 -0400 In-Reply-To: <4E119622.1030709@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 07/04/2011 12:29 PM, Paolo Bonzini wrote: > On 07/04/2011 09:26 AM, Hannes Reinecke wrote: >>> >> Cool. >> Exactly what I need. >> >> FWIW, feel free to add my 'Acked-by' to it. >> >> Any chance of getting them included? > > I'm not very tied to pvscsi; I just needed an HBA that is not a joke > by modern standards :) to play with the SCSI layer. There may be > hope that megasas will come before pvscsi or eliminate the need for > it altogether. So, feel free to pick up patches 5-8 from that series. > Hmm. My goal was actually to get the megasas HBA emulation upstream. When sticking it behind another set of patches chances are not=20 exactly increasing. However, it would certainly make my life easier. > That said, note that scsi-generic does *not* support scatter/gather > in that series, so you should still make sure the fallback paths > work well. :) In pvscsi I added a qdev property to toggle > scatter/gather, it was useful for benchmarking. > Have to check. My patchset did, so it should be reasonably easy to=20 port that one to your infrastructure. However, I probably will see to fixup the megasas emulation with the=20 current infrastructure, get that in, and then move over to the iovec=20 infrastructure. But if you promise to merge the iovec infrastructure I'm more than=20 willing to fixup the scsi-generic backend. Just say the word. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qdie2-0006uI-AQ for qemu-devel@nongnu.org; Mon, 04 Jul 2011 08:52:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qdie0-0001QB-MV for qemu-devel@nongnu.org; Mon, 04 Jul 2011 08:52:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51973 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qdie0-0001Q7-AW for qemu-devel@nongnu.org; Mon, 04 Jul 2011 08:52:56 -0400 Message-ID: <4E11B7A4.8030807@suse.de> Date: Mon, 04 Jul 2011 14:52:52 +0200 From: Hannes Reinecke MIME-Version: 1.0 References: <1309534555-22178-1-git-send-email-hare@suse.de> <1309534555-22178-2-git-send-email-hare@suse.de> <1309534555-22178-3-git-send-email-hare@suse.de> <1309534555-22178-4-git-send-email-hare@suse.de> <4E0F2215.4040307@suse.de> <4E107E66.3030001@redhat.com> <4E115A21.8010003@suse.de> <4E115EFD.7020607@redhat.com> <4E116B32.702@suse.de> <4E119622.1030709@redhat.com> In-Reply-To: <4E119622.1030709@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/3] megasas: LSI Megaraid SAS emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "kvm@vger.kernel.org" , Alexander Graf , Stefan Haynoczi , qemu-devel@nongnu.org On 07/04/2011 12:29 PM, Paolo Bonzini wrote: > On 07/04/2011 09:26 AM, Hannes Reinecke wrote: >>> >> Cool. >> Exactly what I need. >> >> FWIW, feel free to add my 'Acked-by' to it. >> >> Any chance of getting them included? > > I'm not very tied to pvscsi; I just needed an HBA that is not a joke > by modern standards :) to play with the SCSI layer. There may be > hope that megasas will come before pvscsi or eliminate the need for > it altogether. So, feel free to pick up patches 5-8 from that series. > Hmm. My goal was actually to get the megasas HBA emulation upstream. When sticking it behind another set of patches chances are not=20 exactly increasing. However, it would certainly make my life easier. > That said, note that scsi-generic does *not* support scatter/gather > in that series, so you should still make sure the fallback paths > work well. :) In pvscsi I added a qdev property to toggle > scatter/gather, it was useful for benchmarking. > Have to check. My patchset did, so it should be reasonably easy to=20 port that one to your infrastructure. However, I probably will see to fixup the megasas emulation with the=20 current infrastructure, get that in, and then move over to the iovec=20 infrastructure. But if you promise to merge the iovec infrastructure I'm more than=20 willing to fixup the scsi-generic backend. Just say the word. Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)