Re: [PATCH] OMAP4: I2C: Enable FIFO usage for OMAP4

[Shubhrajyoti <shubhrajyoti-l0cyMroinI0@public.gmane.org>]

On Friday 01 July 2011 04:20 AM, Kevin Hilman wrote:
> Shubhrajyoti<shubhrajyoti-l0cyMroinI0@public.gmane.org>  writes:
>
>> On Thursday 30 June 2011 04:53 AM, Kevin Hilman wrote:
>>> Shubhrajyoti D<shubhrajyoti-l0cyMroinI0@public.gmane.org>   writes:
>>>
>>>> Currently the fifo depth is set to zero for OMAP4 which disables
>>>> the FIFO usage. This patch enables the FIFO usage for I2C transactions
>>>> on OMAP4 also.
>>> Do you know the history of why the FIFO depth was set to zero?  A
>>> summary of that history would greatly help reviewers.
Looks like it is disabled in the initial bring up and some how didn’t 
get enabled.
All I could find is
http://www.mail-archive.com/linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg01404.html

>>>> Reported-By:Nishanth Menon<nm-l0cyMroinI0@public.gmane.org>
>>> minor: missing space after ':'
Yes will fix it.
>>>> Signed-off-by: Shubhrajyoti D<shubhrajyoti-l0cyMroinI0@public.gmane.org>
>>> Tested on what platforms?   OMAP3 also?
>> OMAP4 and OMAP3
> Please add a brief summary of what platforms it was tested on in the
> changelog.
Will update it
>>> Could you please rebase this onto my for_3.1/i2c-andy branch[1] where we
>>> have a large series of I2C patches queued up for the v3.1 merge window
>>> already?
>> OK will rebase and resend.
Sent a rebased version.
> Thanks,
>
> Kevin