Re: [PATCH 1/4] include: Add driver api for user confirmation

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

Hi Jeevaka,

On 07/06/2011 05:06 AM, Jeevaka Badrappan wrote:
> ---
>  include/stk.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/stk.h b/include/stk.h
> index c276c84..9a63917 100644
> --- a/include/stk.h
> +++ b/include/stk.h
> @@ -47,6 +47,7 @@ struct ofono_stk_driver {
>  	void (*terminal_response)(struct ofono_stk *stk,
>  					int length, const unsigned char *resp,
>  					ofono_stk_generic_cb_t cb, void *data);
> +	void (*user_confirmation)(struct ofono_stk *stk, gboolean confirm);

Please don't use glib types in public API.  Use ofono_bool_t here instead.

>  };
>  
>  int ofono_stk_driver_register(const struct ofono_stk_driver *d);

Regards,
-Denis