From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2] emulator: fix CCWA for PTS
Date: Wed, 06 Jul 2011 04:40:21 -0500 [thread overview]
Message-ID: <4E142D85.7060204@gmail.com> (raw)
In-Reply-To: <1309445574-9891-1-git-send-email-frederic.danis@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
Hi Frédéric,
On 06/30/2011 09:52 AM, Frédéric Danis wrote:
> During test TP/TCA/BV-05-I [Terminate Ongoing Call – While Call Waiting]
> PTS fails if multiple +CCWA are sent (waiting for 1st phone number when
> waiting one becomes incoming, intead of 2nd phone number).
> So, send only 1 +CCWA.
>
> Update RING timer management to be started as soon as an incoming call
> exists, and retrieve +CLIP info for incoming or waiting call (in case
> of waiting call becoming incoming call, call indicator changes before
> internal call status is updated)
>
> Force to send +CCWA (if needed) on reception of AT+CCWA=1
> ---
> src/emulator.c | 95 ++++++++++++++++++++++++++++++++++---------------------
> 1 files changed, 59 insertions(+), 36 deletions(-)
>
I applied this patch, but added a small refactoring commit afterwards to
make the logic a bit more readable. Can you double check that I didn't
screw anything up?
Regards,
-Denis
prev parent reply other threads:[~2011-07-06 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 14:52 [PATCH v2] emulator: fix CCWA for PTS =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2011-07-06 9:40 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E142D85.7060204@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.