All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions
Date: Wed, 06 Jul 2011 12:24:24 +0200	[thread overview]
Message-ID: <4E1437D8.3030103@redhat.com> (raw)
In-Reply-To: <484E8730-8686-4FBE-9C50-2211C9C4E929@suse.de>

> diff --git a/exec.c b/exec.c
> index 5f2f87e..f281ba4 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -4127,7 +4127,8 @@ void cpu_physical_memory_unmap(void *buffer, target_phys_addr_t len,
>   }
>
>   /* warning: addr must be aligned */
> -uint32_t ldl_phys(target_phys_addr_t addr)
> +static inline uint32_t ldl_phys_internal(target_phys_addr_t addr,
> +                                         enum device_endian endian)

You probably need the __always_inline__ attribute to really convince GCC 
to inline this.

Paolo

  reply	other threads:[~2011-07-06 10:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05 16:28 [Qemu-devel] [PATCH 0/9] Don't use ld./st._phys in hw/ Alexander Graf
2011-07-05 16:28 ` [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st functions Alexander Graf
2011-07-05 21:48   ` Blue Swirl
2011-07-05 21:55     ` Alexander Graf
2011-07-05 22:05       ` Blue Swirl
2011-07-05 22:13         ` Alexander Graf
2011-07-05 22:22           ` Blue Swirl
2011-07-05 22:40             ` Alexander Graf
2011-07-06 10:24               ` Paolo Bonzini [this message]
2011-07-06 11:34                 ` Alexander Graf
2011-07-06 13:03                   ` Hannes Reinecke
2011-07-06 13:18                     ` Alexander Graf
2011-07-06 13:30                     ` Paolo Bonzini
2011-07-05 16:28 ` [Qemu-devel] [PATCH 2/9] hpet: use specific endian ld/st_phys Alexander Graf
2011-07-05 16:28 ` [Qemu-devel] [PATCH 3/9] intel-hda: " Alexander Graf
2011-07-05 16:28 ` [Qemu-devel] [PATCH 4/9] msi: " Alexander Graf
2011-07-05 16:28 ` [Qemu-devel] [PATCH 5/9] msix: " Alexander Graf
2011-07-05 16:28 ` [Qemu-devel] [PATCH 6/9] pl080: " Alexander Graf
2011-07-12 20:46   ` Peter Maydell
2011-07-05 16:28 ` [Qemu-devel] [PATCH 7/9] ppc405_uc: " Alexander Graf
2011-07-05 16:28 ` [Qemu-devel] [PATCH 8/9] s390-virtio: " Alexander Graf
2011-07-05 16:28 ` [Qemu-devel] [PATCH 9/9] spapr: " Alexander Graf
2011-07-05 21:53 ` [Qemu-devel] [PATCH 0/9] Don't use ld./st._phys in hw/ Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1437D8.3030103@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.