From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35638)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hare@suse.de>) id 1QeRlJ-0005VD-D4
	for qemu-devel@nongnu.org; Wed, 06 Jul 2011 09:03:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hare@suse.de>) id 1QeRlH-0004a2-Bg
	for qemu-devel@nongnu.org; Wed, 06 Jul 2011 09:03:29 -0400
Received: from cantor2.suse.de ([195.135.220.15]:48420 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hare@suse.de>)
	id 1QeRlG-0004Zj-Uz
	for qemu-devel@nongnu.org; Wed, 06 Jul 2011 09:03:27 -0400
Message-ID: <4E145D1C.9050506@suse.de>
Date: Wed, 06 Jul 2011 15:03:24 +0200
From: Hannes Reinecke <hare@suse.de>
MIME-Version: 1.0
References: <1309883290-17595-1-git-send-email-agraf@suse.de>	<1309883290-17595-2-git-send-email-agraf@suse.de>	<CAAu8pHu-uVciPeHy9kNmdeUXTj3rLWwpukB7T+J1FodpN5koEg@mail.gmail.com>	<A9909ED1-5998-4B92-A3E2-B2892EC098DB@suse.de>	<CAAu8pHugzOk6vxvxQqbLgmwnNfZ1tO+VsFRgdTFA8jkVJCf60w@mail.gmail.com>	<88EE018B-0308-48B5-80F8-B83D744E41A2@suse.de>	<CAAu8pHvsXbJZG0nA7SPGvSNo-7LKnW=bZrFnqG3q1zSCBTTGkA@mail.gmail.com>	<484E8730-8686-4FBE-9C50-2211C9C4E929@suse.de>	<4E1437D8.3030103@redhat.com>
	<3DEFAA16-DAD1-4F26-A4C6-A8C4CB1E11B4@suse.de>
In-Reply-To: <3DEFAA16-DAD1-4F26-A4C6-A8C4CB1E11B4@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/9] exec: add endian specific phys ld/st
 functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

On 07/06/2011 01:34 PM, Alexander Graf wrote:
>
>
>
>
> On 06.07.2011, at 12:24, Paolo Bonzini<pbonzini@redhat.com>  wrote:
>
>>> diff --git a/exec.c b/exec.c
>>> index 5f2f87e..f281ba4 100644
>>> --- a/exec.c
>>> +++ b/exec.c
>>> @@ -4127,7 +4127,8 @@ void cpu_physical_memory_unmap(void *buffer, ta=
rget_phys_addr_t len,
>>>   }
>>>
>>>   /* warning: addr must be aligned */
>>> -uint32_t ldl_phys(target_phys_addr_t addr)
>>> +static inline uint32_t ldl_phys_internal(target_phys_addr_t addr,
>>> +                                         enum device_endian endian)
>>
>> You probably need the __always_inline__ attribute to really convince G=
CC to inline this.
>
> There's a define in osdep.h that converts inline into always_inline :)
>
Btw, while you're at it:

uint32_t ldub_phys(target_phys_addr_t addr);
uint32_t lduw_phys(target_phys_addr_t addr);

Hmm? ldub is supposed to read an 'unsigned byte' (uint8_t),
and lduw is supposed to read an 'unsigned word' (uint16_t).

Why does it return an uint32_t?

Cheers,

Hannes
--=20
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg
GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)