All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Raphaël Assénat" <raph@8d.com>
To: "Premi, Sanjeev" <premi@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] AM3505/3517 ZCN package support
Date: Wed, 06 Jul 2011 12:54:49 -0400	[thread overview]
Message-ID: <4E149359.1090400@8d.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB593024D9B4CA5@dbde02.ent.ti.com>

On 06/07/11 12:11 PM, Premi, Sanjeev wrote:
>> -----Original Message-----
>> From: linux-omap-owner@vger.kernel.org 
>> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Raphaël Assénat
>> Sent: Wednesday, July 06, 2011 8:59 PM
>> To: linux-omap@vger.kernel.org
>> Subject: [PATCH] AM3505/3517 ZCN package support
>>
>> This patch adds support for the AM35xx ZCN package specific muxmodes.
>>
>> Signed-off-by: Raphael Assenat <raph@8d.com>
>>
> 
> [sp] Few quick comments below:
Thank you for your comments. I just sent an updated version according to them.


>> +#define _OMAP3_NULL_MUXENTRY(M0) _OMAP3_MUXENTRY(M0, 0, 
>> NULL, NULL,	\
>> +				NULL, NULL, NULL, NULL, NULL, NULL)
>> +
>>  /*
>>   * Superset of all mux modes for omap3
>>   */
>> @@ -651,51 +654,50 @@ static struct omap_mux __initdata 
>> omap3_muxmodes[] = {
>>  		"gpio_166", NULL, NULL, "safe_mode"),
>>  
>>  	/* Only on 3630, see omap36xx_cbp_subset for the signals */
>> -	_OMAP3_MUXENTRY(GPMC_A11, 0,
>> -		NULL, NULL, NULL, NULL,
>> -		NULL, NULL, NULL, NULL),
> [snip]...[snip]
>> +	_OMAP3_NULL_MUXENTRY(GPMC_A11),
>> +	_OMAP3_NULL_MUXENTRY(SAD2D_MBUSFLAG),
>> +	_OMAP3_NULL_MUXENTRY(SAD2D_MREAD),
> 
> [sp] These changes don't go with the current patch description.
>      You may want to keep them in a separate patch; and use here.
Ok, I will send another patch for this that will apply on top of the ZCN
patch.

Regards,
Raphaël Assénat
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2011-07-06 16:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-06 15:29 [PATCH] AM3505/3517 ZCN package support Raphaël Assénat
2011-07-06 16:11 ` Premi, Sanjeev
2011-07-06 16:54   ` Raphaël Assénat [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E149359.1090400@8d.com \
    --to=raph@8d.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=premi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.