From: Pavel Roskin <proski@gnu.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Henry Ptasinski <henryp@broadcom.com>,
linville@tuxdriver.com, gregkh@suse.de,
devel@linuxdriverproject.org, linux-wireless@vger.kernel.org,
Brett Rudley <brudley@broadcom.com>,
Arend Van Spriel <arend@broadcom.com>,
Roland Vossen <rvossen@broadcom.com>,
Zhenhui Lin <frankyl@broadcom.com>
Subject: Re: [RFC] Move brcm80211 to mainline
Date: Wed, 06 Jul 2011 20:58:11 -0400 [thread overview]
Message-ID: <4E1504A3.1070801@gnu.org> (raw)
In-Reply-To: <CACna6rx5EyZ-=2XgWawdN_Qu2t1K1sdHZydZFW6=TiX2QUwMfw@mail.gmail.com>
On 07/06/2011 08:40 PM, Rafał Miłecki wrote:
> Short question, without commenting on brcm80211 code yet:
>
> Why should we want 2 mainline drivers for the same hardware?
Also, checkpatch.pl finds a lot of bad stuff:
total: 1 errors, 1505 warnings, 105454 lines checked
$ scripts/checkpatch.pl 0001-wireless-testing-add-brcm80211.patch >Log
$ egrep '^(WARNING|ERROR)' Log |sort |uniq -c
1 ERROR: do not use assignment in if condition
76 WARNING: braces {} are not necessary for any arm of this statement
205 WARNING: braces {} are not necessary for single statement blocks
4 WARNING: consider using a completion
11 WARNING: consider using kstrto* in preference to simple_strtoul
20 WARNING: do not add new typedefs
5 WARNING: externs should be avoided in .c files
1164 WARNING: line over 80 characters
20 WARNING: Use of volatile is usually wrong: see
Documentation/volatile-considered-harmful.txt
That's the "error". It should be easy to fix.
ERROR: do not use assignment in if condition
#35077: FILE: drivers/net/wireless/brcm80211/brcmsmac/main.c:261:
+ if ((cfg = (wlc)->bsscfg[idx]))
20 typedefs seems excessive to me.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2011-07-07 0:58 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 0:20 [RFC] Move brcm80211 to mainline Henry Ptasinski
2011-07-07 0:40 ` Rafał Miłecki
2011-07-07 0:58 ` Pavel Roskin [this message]
2011-07-07 1:45 ` Greg KH
2011-07-07 14:46 ` Henry Ptasinski
2011-07-07 14:58 ` Greg KH
2011-07-07 21:55 ` Henry Ptasinski
2011-07-07 22:04 ` Greg KH
2011-07-07 22:25 ` Pavel Roskin
2011-07-07 15:17 ` Jonas Gorski
2011-07-07 21:21 ` Henry Ptasinski
2011-07-07 0:45 ` Pavel Roskin
2011-07-07 15:01 ` Henry Ptasinski
2011-08-24 22:28 ` [PATCH v2] " Henry Ptasinski
2011-08-24 22:53 ` Greg KH
2011-08-24 23:17 ` Henry Ptasinski
2011-08-24 23:47 ` Greg KH
2011-08-24 23:54 ` Joe Perches
2011-08-25 0:42 ` Henry Ptasinski
2011-08-25 0:52 ` Joe Perches
2011-08-25 1:11 ` Henry Ptasinski
2011-08-25 2:23 ` Greg KH
2011-08-25 2:45 ` Joe Perches
2011-08-25 5:02 ` Johannes Berg
2011-09-30 21:54 ` Arend Van Spriel
2011-09-30 22:11 ` Luis R. Rodriguez
2011-08-24 23:05 ` Dan Carpenter
2011-08-25 0:49 ` Henry Ptasinski
2011-08-24 23:10 ` Aaro Koskinen
2011-08-24 23:18 ` Henry Ptasinski
2011-08-24 23:54 ` Aaro Koskinen
2011-08-24 23:41 ` Jonas Gorski
2011-08-25 0:20 ` Henry Ptasinski
2011-08-25 8:53 ` Michael Büsch
2011-08-25 10:34 ` Jonas Gorski
2011-08-25 17:59 ` Henry Ptasinski
2011-08-25 21:07 ` Rafał Miłecki
2011-08-25 21:09 ` Rafał Miłecki
2011-08-26 17:58 ` Henry Ptasinski
2011-08-25 20:55 ` Rafał Miłecki
2011-08-25 21:11 ` Rafał Miłecki
2011-08-25 21:23 ` Larry Finger
2011-08-26 17:55 ` Henry Ptasinski
2011-08-26 19:37 ` Rafał Miłecki
2011-08-26 19:45 ` Rafał Miłecki
2011-08-27 12:05 ` Rafał Miłecki
2011-08-27 13:18 ` Michael Büsch
2011-08-27 13:58 ` Rafał Miłecki
2011-08-30 13:02 ` David Woodhouse
2011-08-27 14:35 ` Dan Carpenter
2011-08-27 14:50 ` Greg KH
2011-08-27 15:08 ` Rafał Miłecki
2011-08-27 15:12 ` Rafał Miłecki
2011-08-27 16:45 ` Hauke Mehrtens
2011-08-27 15:21 ` Greg KH
2011-08-27 15:27 ` Rafał Miłecki
2011-08-30 1:42 ` Henry Ptasinski
2011-08-30 4:28 ` Greg KH
2011-08-30 6:22 ` Johannes Berg
2011-08-30 8:31 ` Rafał Miłecki
2011-08-30 9:28 ` Michael Büsch
2011-08-31 12:31 ` Rafał Miłecki
2011-08-30 6:17 ` Rafał Miłecki
2011-09-10 16:48 ` Rafał Miłecki
2011-08-30 18:14 ` Greg KH
2011-08-31 17:55 ` Luis R. Rodriguez
2011-08-31 18:33 ` Greg KH
2011-08-31 18:58 ` Luis R. Rodriguez
2011-08-31 11:55 ` Hauke Mehrtens
2011-08-31 14:18 ` John W. Linville
2011-08-31 17:46 ` Luis R. Rodriguez
2011-08-31 17:47 ` Luis R. Rodriguez
2011-08-27 14:59 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1504A3.1070801@gnu.org \
--to=proski@gnu.org \
--cc=arend@broadcom.com \
--cc=brudley@broadcom.com \
--cc=devel@linuxdriverproject.org \
--cc=frankyl@broadcom.com \
--cc=gregkh@suse.de \
--cc=henryp@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rvossen@broadcom.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.