From: Liam Girdwood <lrg@ti.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: ak4642: fixup snd_soc_update_bits mask for PW_MGMT2
Date: Thu, 7 Jul 2011 10:20:38 +0100 [thread overview]
Message-ID: <4E157A66.8040208@ti.com> (raw)
In-Reply-To: <87liwadhyr.wl%kuninori.morimoto.gx@renesas.com>
On 07/07/11 01:58, Kuninori Morimoto wrote:
> mask didn't cover update-data
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> This patch based on asoc/for-3.1
>
> sound/soc/codecs/ak4642.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/ak4642.c b/sound/soc/codecs/ak4642.c
> index 4be0570..65f4604 100644
> --- a/sound/soc/codecs/ak4642.c
> +++ b/sound/soc/codecs/ak4642.c
> @@ -357,7 +357,7 @@ static int ak4642_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
> default:
> return -EINVAL;
> }
> - snd_soc_update_bits(codec, PW_MGMT2, MS, data);
> + snd_soc_update_bits(codec, PW_MGMT2, MS | MCKO | PMPLL, data);
> snd_soc_update_bits(codec, MD_CTL1, BCKO_MASK, bcko);
>
> /* format type */
Acked-by: Liam Girdwood <lrg@ti.com>
next prev parent reply other threads:[~2011-07-07 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 0:58 [PATCH] ASoC: ak4642: fixup snd_soc_update_bits mask for PW_MGMT2 Kuninori Morimoto
2011-07-07 9:20 ` Liam Girdwood [this message]
2011-07-07 16:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E157A66.8040208@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.