From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37081)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QerxA-0003bP-0n
	for qemu-devel@nongnu.org; Thu, 07 Jul 2011 13:01:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1Qerma-0007tM-5c
	for qemu-devel@nongnu.org; Thu, 07 Jul 2011 12:50:33 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:48363)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QermZ-0007tI-Ug
	for qemu-devel@nongnu.org; Thu, 07 Jul 2011 12:50:32 -0400
Message-ID: <4E15E3D4.6020701@mail.berlios.de>
Date: Thu, 07 Jul 2011 18:50:28 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <20110707130255.76f47cd0@doriath>
	<4E15DC0B.7050608@linux.vnet.ibm.com>
In-Reply-To: <4E15DC0B.7050608@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Error: Fix build when qemu-common.h is not
	included
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

Am 07.07.2011 18:17, schrieb Michael Roth:
> On 07/07/2011 11:02 AM, Luiz Capitulino wrote:
>> Commit e4ea5e2d0e0e4c5188ab45b66f3195062ae059dc added the use of
>> the macro GCC_FMT_ATTR to error.h, however qemu-common.h is not
>> included by error.h
>>
>> This will cause a build error when files including error.h
>> don't include qemu-common.h. Not an issue today because the only
>> file including it is json-parser.h and it does include
>> qemu-common.h, but let's fix it.
>>
>> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
>> ---
>>   error.h |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)

The same argument could be applied to more QEMU *.h files
which also work only after qemu-common.h. Otherwise, including
qemu-common.h in *.c files would rarely be needed.

As far as I remember, the *.h files used to be more self-contained
some years ago, but then the strategy changed and central files
like qemu-common.h were introduced.

I personally prefer self-contained include files like error.h
(before my patch and after your patch), but I'm afraid that
the QEMU way is different.

Cheers,
Stefan W.