All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Grac <mgrac@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH][fence-agents] fence_eaton_snmp: add support for Eaton Switched ePDU
Date: Fri, 08 Jul 2011 10:39:11 +0200	[thread overview]
Message-ID: <4E16C22F.3000006@redhat.com> (raw)
In-Reply-To: <CAFm_bUhuEYpiLz2bti+yzyBOsApAvF9rJ3gOS=L0uEDFDq4aJQ@mail.gmail.com>

Hi Arnaud,

On 07/04/2011 08:59 PM, Arnaud Quette wrote:
> Hi,
>
> you will find attached  a patch that adds support for Eaton Switched 
> ePDU to fence_eaton_snmp.
> please consider applying it.

What do you think about replacing magic numbers (+1, -1, -3) with some 
constants with names?

m,



  parent reply	other threads:[~2011-07-08  8:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04 18:59 [Cluster-devel] [PATCH][fence-agents] fence_eaton_snmp: add support for Eaton Switched ePDU Arnaud Quette
2011-07-05  7:38 ` Fabio M. Di Nitto
2011-07-05  8:15   ` Arnaud Quette
2011-07-08  8:39 ` Marek Grac [this message]
2011-07-10 20:10   ` Arnaud Quette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E16C22F.3000006@redhat.com \
    --to=mgrac@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.