From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Ido Yariv <ido@wizery.com>
Cc: davinci-linux-open-source@linux.davincidsp.com,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 2/5] arm: davinci: Allow EVENTQ_0 as a default queue
Date: Fri, 08 Jul 2011 14:25:23 +0400 [thread overview]
Message-ID: <4E16DB13.90806@mvista.com> (raw)
In-Reply-To: <1310074390-4277-3-git-send-email-ido@wizery.com>
Hello.
On 08-07-2011 1:33, Ido Yariv wrote:
> Davinci platforms may define a default queue for each channel
> controller. If one is not defined, the default queue is set to EVENTQ_1.
> However, there's no way to distinguish between an unset default queue to
> one that is set to EVENTQ_0, as EVENTQ_0 = 0.
> In order to keep existing behaviour on platforms which don't specify a
> default_queue member, the default_queue member was modified to be a
> pointer to enum dma_event_q. A NULL value means that this member was not
> specified.
Mmm, perhaps it's better to drop the default EVENTQ_1 concept and
explicitly initilaize that field for every SoC. It's also possible to offset
the event queue number by 1. I don't like the pointer solution.
> Signed-off-by: Ido Yariv<ido@wizery.com>
WBR, Sergei
next prev parent reply other threads:[~2011-07-08 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 21:33 [PATCH 0/5] arm: davinci: DA850: wl12xx expansion board Ido Yariv
2011-07-07 21:33 ` [PATCH 1/5] arm: davinci: Fix low level gpio irq handlers' argument Ido Yariv
2011-07-07 21:33 ` [PATCH 2/5] arm: davinci: Allow EVENTQ_0 as a default queue Ido Yariv
2011-07-08 10:25 ` Sergei Shtylyov [this message]
2011-07-08 14:27 ` Ido Yariv
2011-07-07 21:33 ` [PATCH 3/5] arm: davinci: DA850: Set a default queue for CC1 Ido Yariv
2011-07-07 21:33 ` [PATCH 4/5] arm: davinci: mmc: Add support for set_power callback Ido Yariv
2011-07-07 21:33 ` [PATCH 5/5] arm: davinci: DA850: Add wl12xx expansion board support Ido Yariv
2011-07-08 10:39 ` Sergei Shtylyov
2011-07-08 14:27 ` Ido Yariv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E16DB13.90806@mvista.com \
--to=sshtylyov@mvista.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=ido@wizery.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.