All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] non-migratable devices
Date: Fri, 08 Jul 2011 14:05:01 +0200	[thread overview]
Message-ID: <4E16F26D.40404@redhat.com> (raw)
In-Reply-To: <4E16EE6A.6000506@redhat.com>

On 07/08/2011 01:47 PM, Gerd Hoffmann wrote:
>
>
>> scsi-cd is new in 0.15, older versions have scsi-disk only. That's why
>> we should take the occasion to add the empty vmstate at least to it.
>
> Ok, good opportunity in that specific case.
>
>> For other devices, it's better to make the breakage in a single version.
>> It also allows to make 0.15 the "flag day" where each device shall have
>> a VMState or the entire VM will not be migratable.
>
> Not that easy given that we didn't fully migrate to vmstate yet,
> otherwise we could simply fail migration in case we find any device with
> qdev->vmsd == NULL.

You can always add

#define VMSD_NONE  ((const VMStateDescription *) 1)

>> If desired, in the
>> future we can revert this behavior for pc-0.14 and earlier machines.
>
> And I'm still looking for a sane way to handle *this*.

One possibility is to add device name remapping to machine types, like 
"ide is actually ide-0.14 when using pc-0.14" and put a different 
VMState in ide-0.14.

Paolo

  reply	other threads:[~2011-07-08 12:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-08  8:53 [Qemu-devel] [PATCH 0/3] non-migratable devices Gerd Hoffmann
2011-07-08  8:53 ` [Qemu-devel] [PATCH 1/3] vmstate: add no_migrate flag to VMStateDescription Gerd Hoffmann
2011-07-08 14:26   ` Anthony Liguori
2011-07-08 15:44     ` Gerd Hoffmann
2011-07-08 16:04       ` Gerd Hoffmann
2011-07-08 17:07         ` Anthony Liguori
2011-07-11  6:29           ` Gerd Hoffmann
2011-07-08  8:53 ` [Qemu-devel] [PATCH 2/3] ahci doesn't support migration Gerd Hoffmann
2011-07-08  8:53 ` [Qemu-devel] [PATCH 3/3] ehci " Gerd Hoffmann
2011-07-08  9:54 ` [Qemu-devel] [PATCH 0/3] non-migratable devices Paolo Bonzini
2011-07-08  9:59   ` Gerd Hoffmann
2011-07-08 10:17     ` Paolo Bonzini
2011-07-08 11:47       ` Gerd Hoffmann
2011-07-08 12:05         ` Paolo Bonzini [this message]
2011-07-08 12:47           ` Gerd Hoffmann
2011-07-08 12:59             ` Paolo Bonzini
2011-07-08 13:21               ` Gerd Hoffmann
2011-07-08 11:45     ` Markus Armbruster
2011-07-08 13:43 ` [Qemu-devel] [PATCH 4/3] vmstate: complain about devices without vmstate Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E16F26D.40404@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.