From: "H. Peter Anvin" <hpa@zytor.com>
To: Brian Gerst <brgerst@gmail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86-64: Simplify cpu_has_invlpg
Date: Sun, 10 Jul 2011 11:18:50 -0700 [thread overview]
Message-ID: <4E19ED0A.9000709@zytor.com> (raw)
In-Reply-To: <1310306000-2447-1-git-send-email-brgerst@gmail.com>
On 07/10/2011 06:53 AM, Brian Gerst wrote:
> Define CONFIG_X86_INVLPG for 64-bit too, which simplifies the code.
>
> Signed-off-by: Brian Gerst <brgerst@gmail.com>
I think a much better way to do this kind of stuff is to define
Linux-specific CPU feature bits (which we already have quite a few of).
That way they fall into the same mechanism as everything else that has
switches on CPU features, we can use alternatives, and so on.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2011-07-10 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 13:53 [PATCH 1/2] x86-64: Simplify cpu_has_invlpg Brian Gerst
2011-07-10 13:53 ` [PATCH 2/2] x86: Simplify X86_CMPXCHG, CMPXCHG_LOCAL, and X86_XADD Brian Gerst
2011-07-10 16:35 ` Pekka Enberg
2011-07-10 16:34 ` [PATCH 1/2] x86-64: Simplify cpu_has_invlpg Pekka Enberg
2011-07-10 18:18 ` H. Peter Anvin [this message]
2011-07-11 11:50 ` Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E19ED0A.9000709@zytor.com \
--to=hpa@zytor.com \
--cc=brgerst@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.