From: Jonathan Cameron <jic23@cam.ac.uk>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] Suggested additions to hwmon sysfs ABI
Date: Mon, 11 Jul 2011 08:53:09 +0000 [thread overview]
Message-ID: <4E1AB9F5.8080701@cam.ac.uk> (raw)
In-Reply-To: <20110709170759.GA5750@ericsson.com>
On 07/09/11 18:07, Guenter Roeck wrote:
> Hi all,
>
> while adding support for more PMBus devices, I noticed that many of the chips
> support attributes which are not currently available in the sysfs ABI.
>
> Here is a (not necessarily complete) list.
>
> ---
>
> Historic minimum attributes:
> vout_min vin_min temp_min
> MAX34440 x
> MAX34441 x
> LTC2978 x x x
>
> Peak (historic maximum) attributes:
>
> pin_peak vin_peak vout_peak iout_peak temp_peak
> MAX34440 x x x
> MAX34441 x x x
> MAX8688 x x x
> MAX16064 x x
> ADM1275 x x x
> ADM1276 x x x x
> LTC2978 x x x
> LM25066 x (1)
> LM5064 x (1)
> LM5066 x (1)
> ZLxxxx (2) x (3)
>
> Average attributes:
>
> vin_avg vout_avg iin_avg pin_avg
> LM25066 x x x x (1)
> LM5064 x x x x (1)
> LM5066 x x x x (1)
>
> Notes:
> 1) In addition to instantaneous power measurements
> 2) All Intersil / Zilker Labs power management chips
> 3) Only available through SNAPSHOT command, which reads a total of 32 bytes.
> Also see Intersil / Zilker Labs AN2033.
>
> ---
>
> Based on this list, I suggest adding the following attributes to the ABI.
>
> in[0-*]_input_lowest
> in[0-*]_input_highest
> in[0-*]_average
> in[0-*]_reset_history
>
> curr[1-*]_input_lowest
> curr[1-*]_input_highest
> curr[1-*]_average
> curr[1-*]_reset_history
>
> temp[1-*]_input_lowest
> temp[1-*]_input_highest
> temp[1-*]_average
> temp[1-*]_reset_history
>
> It might also be necessary to modify the sensors command to support both instantaneous
> and average/peak power readings at the same time.
How are you going to do peak power?
Otherwise, Looks sensible. Ran into this in IIO as well, we went with peak, but highest / lowest
works just as well. (not seen the minimum version yet)
>
> Thoughts/comments ?
>
> Thanks,
> Guenter
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-07-11 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 17:07 [lm-sensors] Suggested additions to hwmon sysfs ABI Guenter Roeck
2011-07-11 8:53 ` Jonathan Cameron [this message]
2011-07-11 12:42 ` Guenter Roeck
2011-07-11 14:32 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1AB9F5.8080701@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.