All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Soltys <soltys@ziu.info>
To: fdelawarde@wirelessmundi.com
Cc: netfilter-devel@vger.kernel.org, 631945@bugs.debian.org, kaber@trash.net
Subject: Re: HFSC warning issue
Date: Mon, 11 Jul 2011 13:56:33 +0200	[thread overview]
Message-ID: <4E1AE4F1.6030905@ziu.info> (raw)
In-Reply-To: <1310376412.8036.134.camel@luna.madrid.commsmundi.com>

W dniu 11.07.2011 11:26, François Delawarde pisze:
> Hi all,
> 
> I'm having the same HFSC issues as described here:
> 
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=631945
> 
> Some user reports that he made it work by reverting this patch:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;f=net/sched/sch_hfsc.c;h=47496098d35c2876cd0b5a88e1365922cc369ce9;hp=abd904be428717462395d62adb682023e64e17a5;hb=3b2eb6131e2f6ff646abb0fc69648179b8b70216;hpb=9c01ae58d4fee39e2af5b1379ee5431dd585cf62
> 
> 
> Is this the correct solution? Any "clean" patch I could test that would
> resolve this issue?
> 
> Thanks,
> François.
> 

Hmmm,

This commit in mention is the patch I submitted 
a while ago, namely:

http://kerneltrap.org/mailarchive/linux-netdev/2010/8/30/6284141

Whole rationale and short discussion regarding the 
change is in that thread. 

In a nutshell - it fixed certain scenario which could cause 
bursty traffic, but the change is just a minor adjustment. Let 
me sit a bit on this thing, and why it manages to trigger that 
warning ...

For a quick fix - reverting that commit should be perfectly 
safe - there were no other patches related to this one.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-07-11 12:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11  9:26 HFSC warning issue François Delawarde
2011-07-11 11:56 ` Michal Soltys [this message]
2011-07-11 12:11   ` Michal Soltys
2011-07-11 14:11     ` François Delawarde
2011-07-11 15:07     ` Bug#631945: " 00bormoj
2011-07-12 23:28       ` Michal Soltys
2011-07-15 10:57         ` François Delawarde
  -- strict thread matches above, loose matches on Subject: below --
2011-07-13  9:21 Michal Pokrywka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1AE4F1.6030905@ziu.info \
    --to=soltys@ziu.info \
    --cc=631945@bugs.debian.org \
    --cc=fdelawarde@wirelessmundi.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.