Re: New ctrl framework also enumerates classes

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 07/04/2011 08:30 AM, Hans Verkuil wrote:
> On Monday, July 04, 2011 08:23:10 Hans de Goede wrote:
>> Hi All,
>>
>> One last thing before I really leave on vacation which just popped
>> in my mind as something which I had not mentioned yet.
>>
>> The new ctrl framework also enumerates classes when enumerating
>> ctrls with the next flag. I wonder if this is intentional?
>
> It's absolutely intentional. It's needed to produce the headers of the
> tabs in e.g. qv4l2. It's been part of the spec for several years now.
>
>> IOW if this is a feature or a bug?
>>
>> Either way this confuses various userspace apps, gtk-v4l prints
>> warnings about an unknown control type,
>
> It should just skip such types.
>
>> and v4l2ucp gets a very
>> messed up UI because of this change. Thus unless there are
>> really strong reasons to do this, I suggest we skip classes
>> when enumerating controls.
>
> Those apps should be fixed. If apps see an unknown type, then they should
> always just skip such controls (and later add support for it, of course).

Ok, I will fix those apps (for gtk-v4l I'm involved upstream, for v4l2ucp
I'll fix it for Fedora and submit a patch upstream).

Regards,

Hans