All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH 2/3] netfilter: ipset: hash:net,iface fixed to handle overlapping nets behind different interfaces
Date: Mon, 11 Jul 2011 18:49:32 +0200	[thread overview]
Message-ID: <4E1B299C.2010401@trash.net> (raw)
In-Reply-To: <1310377975-993-3-git-send-email-kadlec@blackhole.kfki.hu>

Am 11.07.2011 11:52, schrieb Jozsef Kadlecsik:
> If overlapping networks with different interfaces was added to
> the set, the type did not handle it properly. Example
> 
> 	ipset create test hash:net,iface
> 	ipset add test 192.168.0.0/16,eth0
> 	ipset add test 192.168.0.0/24,eth1
> 
> Now, if a packet was sent from 192.168.0.0/24,eth0, the type returned
> a match.
> 
> In the patch the algorithm is fixed in order to correctly handle
> overlapping networks.
> 
> Limitation: the same network cannot be stored with more than 64 different
> interfaces in a single set.
> 

Applied, thanks.

  parent reply	other threads:[~2011-07-11 16:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11  9:52 [PATCH 0/3] ipset patches against nf-next Jozsef Kadlecsik
2011-07-11  9:52 ` [PATCH 1/3] netfilter: ipset: Make possible to hash some part of the data element only Jozsef Kadlecsik
2011-07-11  9:52   ` [PATCH 2/3] netfilter: ipset: hash:net,iface fixed to handle overlapping nets behind different interfaces Jozsef Kadlecsik
2011-07-11  9:52     ` [PATCH 3/3] netfilter: ipset: Fix compiler warnings "'hash_ip4_data_next' declared inline after being called" Jozsef Kadlecsik
2011-07-11 16:51       ` Patrick McHardy
2011-07-11 16:49     ` Patrick McHardy [this message]
2011-07-11 16:48   ` [PATCH 1/3] netfilter: ipset: Make possible to hash some part of the data element only Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1B299C.2010401@trash.net \
    --to=kaber@trash.net \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.