From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [RFC v3 31/56] ac97: convert to memory API Date: Tue, 12 Jul 2011 10:14:49 +0300 Message-ID: <4E1BF469.501@redhat.com> References: <1310321709-30770-1-git-send-email-avi@redhat.com> <1310321709-30770-32-git-send-email-avi@redhat.com> <4E1A54ED.7040606@codemonkey.ws> <4E1AD4B4.2080305@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org To: malc Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9825 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753747Ab1GLHPF (ORCPT ); Tue, 12 Jul 2011 03:15:05 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 07/12/2011 01:03 AM, malc wrote: > > > > Here's a new version: > > This one looks acceptable[1], original submission said: > "fixes BAR sizing as well." what was wrong with it? The nabm BAR, for example, was registered as 64 bytes of byte ioports, 128 bytes of word ioports, and 256 bytes of long ioports. I expect this was an error. The new patch preserves the error. > [..snip..] > > P.S. Sans minor inconsistency with trailing commas. > Where I expect more fields, I leave a trailing comma. It makes further patches nicer. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgXBR-0000vN-DT for qemu-devel@nongnu.org; Tue, 12 Jul 2011 03:15:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QgXBQ-0005RB-5a for qemu-devel@nongnu.org; Tue, 12 Jul 2011 03:15:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30509) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgXBP-0005Qc-UH for qemu-devel@nongnu.org; Tue, 12 Jul 2011 03:15:04 -0400 Message-ID: <4E1BF469.501@redhat.com> Date: Tue, 12 Jul 2011 10:14:49 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1310321709-30770-1-git-send-email-avi@redhat.com> <1310321709-30770-32-git-send-email-avi@redhat.com> <4E1A54ED.7040606@codemonkey.ws> <4E1AD4B4.2080305@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v3 31/56] ac97: convert to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 07/12/2011 01:03 AM, malc wrote: > > > > Here's a new version: > > This one looks acceptable[1], original submission said: > "fixes BAR sizing as well." what was wrong with it? The nabm BAR, for example, was registered as 64 bytes of byte ioports, 128 bytes of word ioports, and 256 bytes of long ioports. I expect this was an error. The new patch preserves the error. > [..snip..] > > P.S. Sans minor inconsistency with trailing commas. > Where I expect more fields, I leave a trailing comma. It makes further patches nicer. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.