All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carmelo AMOROSO <carmelo.amoroso@st.com>
To: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] Added proper return code (TPASS) in case of exit without errors.
Date: Tue, 12 Jul 2011 18:01:18 +0200	[thread overview]
Message-ID: <4E1C6FCE.1010402@st.com> (raw)
In-Reply-To: <CAGH67wQ4knG70q-bpPV0fmTOsmf9ciyPN-k65M=ysMk1o5_uFg@mail.gmail.com>

On 12/07/2011 16.38, Garrett Cooper wrote:
> On Tue, Jul 12, 2011 at 1:45 AM, Francesco RUNDO <francesco.rundo@st.com> wrote:
>> From: Francesco Rundo <francesco.rundo@st.com>
>>
>> The "kill05" testcase checks if EPERM is correctly raised by the system.
>> The testcase manages the error exit codes correctly while it didn't return
>> any exit code in case of no errors occured i.e. the system has raised EPERM.
>> The correct exit-code "TPASS" has been added in case of the test works fine without
>> errors.
>>
>> Signed-off-by: Francesco Rundo <francesco.rundo@st.com>
>> Reviewed-by: Carmelo Amoroso <carmelo.amoroso@st.com>
> 
>     Please properly styleize this; this doesn't conform to Linux
> coding standards..

I've noted there is a trailing white space ?
is this the only problem ?

carmelo


> Thanks,
> -Garrett
> 
> ------------------------------------------------------------------------------
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security 
> threats, fraudulent activity, and more. Splunk takes this data and makes 
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 


------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2011-07-12 16:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4e1c09b0.04af2a0a.2ccb.ffffab1eSMTPIN_ADDED@mx.google.com>
2011-07-12 14:38 ` [LTP] [PATCH] Added proper return code (TPASS) in case of exit without errors Garrett Cooper
2011-07-12 16:01   ` Carmelo AMOROSO [this message]
2011-07-12 17:06     ` Garrett Cooper
2011-07-12  8:45 Francesco RUNDO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1C6FCE.1010402@st.com \
    --to=carmelo.amoroso@st.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.