From: James Smart <james.smart@emulex.com>
To: Rob Evers <revers@redhat.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: lpfc_debugfs_dumpHBASlim_data() stack space use
Date: Tue, 12 Jul 2011 22:26:21 -0400 [thread overview]
Message-ID: <4E1D024D.3090205@emulex.com> (raw)
In-Reply-To: <4E1CA720.1040602@redhat.com>
yes - something popped up with a recent change in the compiler.
The following patch addressed this issue.
http://marc.info/?l=linux-scsi&m=130655514918715&w=2
-- james s
On 7/12/2011 3:57 PM, Rob Evers wrote:
> Hi James S.
>
> I noticed:
>
> static int
> lpfc_debugfs_dumpHBASlim_data(struct lpfc_hba *phba, char *buf, int size)
> {
> int len = 0;
> int i, off;
> uint32_t *ptr;
> char buffer[1024];
>
>
> Would 'char *buffer=kmalloc()' be more appropriate here?
>
> Rob
>
prev parent reply other threads:[~2011-07-13 2:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 19:57 lpfc_debugfs_dumpHBASlim_data() stack space use Rob Evers
2011-07-13 2:26 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1D024D.3090205@emulex.com \
--to=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
--cc=revers@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.