From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:55021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QgtN7-0001zc-QE
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 02:56:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QgtN2-00024M-NO
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 02:56:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27145)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QgtN2-0001xf-53
	for qemu-devel@nongnu.org; Wed, 13 Jul 2011 02:56:32 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6D6uUY0016721
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 13 Jul 2011 02:56:30 -0400
Message-ID: <4E1D419B.5060501@redhat.com>
Date: Wed, 13 Jul 2011 08:56:27 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1310478932-25370-1-git-send-email-alevy@redhat.com>
	<1310478932-25370-12-git-send-email-alevy@redhat.com>
In-Reply-To: <1310478932-25370-12-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv3] qxl: QXL_IO_UPDATE_AREA: pass
 ram->update_area directly to update_area
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

   Hi,

> -        QXLRect update = d->ram->update_area;
>           qxl_spice_update_area(d, d->ram->update_surface,
> -&update, NULL, 0, 0);
> +&d->ram->update_area, NULL, 0, 1);

No, -ESECURITY.

With this in place the guest can change the update rect while 
spice-server is working with it.

cheers,
   Gerd