From: Jiri Slaby <jslaby@suse.cz>
To: Greg KH <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
torvalds@linux-foundation.org, stable@kernel.org, lwn@lwn.net,
Joe Perches <joe@perches.com>
Subject: Re: Linux 2.6.32.43
Date: Wed, 13 Jul 2011 23:28:36 +0200 [thread overview]
Message-ID: <4E1E0E04.8030200@suse.cz> (raw)
In-Reply-To: <4E1E0C59.1030100@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
Cced Joe.
On 07/13/2011 11:21 PM, Jiri Slaby wrote:
> On 07/13/2011 11:16 PM, Jiri Slaby wrote:
>> On 07/13/2011 05:45 AM, Greg KH wrote:
>>> Joe Perches (2):
>>> bug.h: Add WARN_RATELIMIT
>>> net: filter: Use WARN_RATELIMIT
>>
>> Hi, this causes a build failure on PPC with minimalistic config (PS3) [1]:
>> net/core/filter.c: In function 'sk_run_filter':
>> net/core/filter.c:297: error: implicit declaration of function
>> 'WARN_RATELIMIT'
>>
>> net/core/filter.c should include linux/bug.h (or linux/kernel.h).
>
> Ah, no, PS3 doesn't have CONFIG_BUG set.
A fix attached. Upstream doesn't need it. There it is all in
linux/ratelimit.h
>> [1]
>> http://gitorious.org/opensuse/kernel-source/blobs/SLE11-SP1/config/ppc/ps3
>>
>> regards,
--
js
suse labs
[-- Attachment #2: ppc-fix-net-core-build.patch --]
[-- Type: text/x-patch, Size: 855 bytes --]
From: Jiri Slaby <jslaby@suse.cz>
Subject: PPC: fix net core build
Patch-mainline: not yet
After "net: filter: Use WARN_RATELIMIT" was applied as a part of
patches.kernel.org/patch-2.6.32.42-43 we are choking at:
net/core/filter.c: In function 'sk_run_filter':
net/core/filter.c:297: error: implicit declaration of function 'WARN_RATELIMIT'
on configs without CONFIG_BUG.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
include/asm-generic/bug.h | 7 +++++++
1 file changed, 7 insertions(+)
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -126,6 +126,13 @@ extern void warn_slowpath_null(const cha
})
#endif
+#ifndef WARN_RATELIMIT
+#define WARN_RATELIMIT(condition, format...) ({ \
+ int __ret_warn_on = !!(condition); \
+ unlikely(__ret_warn_on); \
+})
+#endif
+
#endif
#define WARN_ON_ONCE(condition) ({ \
next prev parent reply other threads:[~2011-07-13 21:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 3:45 Linux 2.6.32.43 Greg KH
2011-07-13 3:46 ` Greg KH
2011-07-13 21:16 ` Jiri Slaby
2011-07-13 21:21 ` Jiri Slaby
2011-07-13 21:28 ` Jiri Slaby [this message]
2011-07-13 21:35 ` Linux 2.6.32.43 (WARN_RATELIMIT) Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1E0E04.8030200@suse.cz \
--to=jslaby@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lwn@lwn.net \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.