From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:32879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhIx7-0001e0-5f for qemu-devel@nongnu.org; Thu, 14 Jul 2011 06:15:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QhIx5-0008MW-Kv for qemu-devel@nongnu.org; Thu, 14 Jul 2011 06:15:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62627) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QhIx5-0008MO-54 for qemu-devel@nongnu.org; Thu, 14 Jul 2011 06:15:27 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6EAFPPN021498 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 14 Jul 2011 06:15:25 -0400 Message-ID: <4E1EC1BA.2010608@redhat.com> Date: Thu, 14 Jul 2011 12:15:22 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1310562411-30538-1-git-send-email-minovotn@redhat.com> <4E1DA7A6.6060104@redhat.com> <4E1EACB9.4040701@redhat.com> <4E1EBA76.8020603@redhat.com> <4E1EBF5F.5030307@redhat.com> In-Reply-To: <4E1EBF5F.5030307@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Introduce "info migrate-times" monitor command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Novotny Cc: qemu-devel@nongnu.org On 07/14/2011 12:05 PM, Michal Novotny wrote: > What do you mean by removing migration.c from the list? Do you mean > doing no modifications to this file? No usage of the time variables in migration.c. > it's about milliseconds It's noise anyway. > The arch_init.c to include savevm-related code doesn't make any sense in > general which is the thing I have to agree but if we want to measure the > ram_save_live() per each stage we need to alter the ram_save_live() > function which is present in the arch_init.c file (this is directly in > vl.c file for RHEL-6 version of qemu however for upstream version we > need to modify arch_init.c to provide the most precise RAM transfer > values per each stage). We can move the ram_save_live() function into > some other file, like savevm.c or vl.c... Is this what you mean by "If > you move that code back to savevm.c" ? The code is in vl.c file for > RHEL-6, not savevm.c and I don't know whether it ever was in savevm.c . I think savevm.c is the right place for it. Alternatively, what about updating the information for ram and disk directly in qemu_savevm_state_begin/iterate/complete (and similarly for loading)? Just change "disk" to "block" so that it matches the parameter of register_savevm_live in block-migration.c. Paolo