From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: MX5: Fix broken leftover TO-2 errata workaround
Date: Thu, 14 Jul 2011 14:39:51 +0200 [thread overview]
Message-ID: <4E1EE397.1030205@denx.de> (raw)
In-Reply-To: <20110714143002.28eb3dc2@archvile>
On 07/14/2011 02:30 PM, David Jander wrote:
>> You have to protect the code related to TO2 with CONFIG_MX51. As I can
>> see, the macro is called for MX.53, too, and the test produces wrong
>> results.
>
> Wow, you are right! So this code was actually broken in more ways than I
> initially thought :-)
Yes, with one shot you hit more bugs...
> Ok, will fix it (again).
> Btw, may I congratulate you for your good work in improving u-boot code
> quality? It is starting to get to a level only known from LKML ;-)
Congratulations go to all participants and reviewers of this ML, who are
helping to improve the quality of the code ;-)
> Clearly the code was not reviewed as well when this was initially submitted.
That is right - some issues was not seen and not fixed in time.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2011-07-14 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 11:56 [U-Boot] [PATCH] ARM: MX5: Fix broken leftover TO-2 errata workaround David Jander
2011-07-14 12:14 ` Stefano Babic
2011-07-14 12:30 ` David Jander
2011-07-14 12:39 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1EE397.1030205@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.