From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [uboot PATCH v2] Add uboot "fdt_high" enviroment variable
Date: Thu, 14 Jul 2011 09:10:13 -0400 [thread overview]
Message-ID: <4E1EEAB5.5020907@gmail.com> (raw)
In-Reply-To: <20110709204019.593.76357.stgit@dave-Dell-System-XPS-L502X>
Hi Dave,
This looks reasonable, with one minor nit...
On 07/09/2011 04:40 PM, David A. Long wrote:
> From: David A. Long<dave.long@linaro.org>
>
> Add a new "fdt_high" enviroment variable. This can be used to control (or prevent) the
> relocation of the flattened device tree on boot. It can be used to prevent relocation
> of the fdt into highmem. The variable behaves similarly to the existing "initrd_high"
> variable.
>
> Signed-off-by: David A. Long<dave.long@linaro.org>
> ---
> README | 9 ++++++++
> common/image.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++----------
> 2 files changed, 58 insertions(+), 11 deletions(-)
>
> diff --git a/README b/README
> index 8bb9c8d..5b95246 100644
> --- a/README
> +++ b/README
> @@ -3281,6 +3281,15 @@ List of environment variables (most likely not complete):
[snip]
> diff --git a/common/image.c b/common/image.c
> index e542a57..7853de0 100644
> --- a/common/image.c
> +++ b/common/image.c
> @@ -1234,8 +1234,10 @@ int boot_relocate_fdt (struct lmb *lmb, char **of_flat_tree, ulong *of_size)
> {
> void *fdt_blob = *of_flat_tree;
> void *of_start = 0;
> + char *fdt_high;
> ulong of_len = 0;
> int err;
> + int disable_relocation=0;
Need spaces around the "="
I will add the spaces before applying the patch unless you send an
updated patch.
Thanks,
gvb
next prev parent reply other threads:[~2011-07-14 13:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 20:40 [U-Boot] [uboot PATCH v2] Add uboot "fdt_high" enviroment variable David A. Long
2011-07-14 13:10 ` Jerry Van Baren [this message]
2011-07-14 13:28 ` David Long
2011-07-14 18:50 ` Grant Likely
2011-07-14 19:12 ` David Long
2011-07-14 19:43 ` Scott Wood
2011-07-14 20:09 ` David Long
2011-07-14 20:21 ` Scott Wood
2011-07-14 21:20 ` David Long
2011-07-14 21:51 ` Scott Wood
2011-07-15 4:39 ` David Long
2011-07-15 2:53 ` Grant Likely
2011-07-16 16:06 ` Jerry Van Baren
2011-07-18 4:45 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1EEAB5.5020907@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.