From: David Vrabel <david.vrabel@citrix.com>
To: Keir Fraser <keir.xen@gmail.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] libxc: set CPUID topology leaf as unsupported for PV guests
Date: Thu, 14 Jul 2011 15:25:57 +0100 [thread overview]
Message-ID: <4E1EFC75.6080500@citrix.com> (raw)
In-Reply-To: <CA44AE04.1DDBE%keir.xen@gmail.com>
On 14/07/11 14:30, Keir Fraser wrote:
> On 14/07/2011 12:50, "David Vrabel" <david.vrabel@citrix.com> wrote:
>
>> libxc: set CPUID topology leaf as unsupported for PV guests
>>
>> The result of a CPUID Extended Topology Enumeration leaf for PV guests
>> is invalid as the level in ECX is ignored. This can cause some guests
>> to loop endlessly when trying to enumerate the topology.
>>
>> Since the physical topology isn't useful to PV guests set the topology
>> leaf as unsupported.
>
> For future reference, you also need to modify
> xen/arch/x86/traps.c:pv_cpuid(), for dom0.
Looking at the code it looks like dom0 would at least see valid data for
the the topology leaf. But I guess the info makes no sense to dom0 as
well as domU guests. Patch sent if you've not already fixed it up.
David
next prev parent reply other threads:[~2011-07-14 14:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 11:50 [PATCH] libxc: set CPUID topology leaf as unsupported for PV guests David Vrabel
2011-07-14 13:30 ` Keir Fraser
2011-07-14 13:56 ` Ian Campbell
2011-07-14 14:25 ` David Vrabel [this message]
2011-07-15 8:41 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1EFC75.6080500@citrix.com \
--to=david.vrabel@citrix.com \
--cc=keir.xen@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.