From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc: Fix device tree padding associated with ramdisk
Date: Thu, 14 Jul 2011 10:47:42 -0400 [thread overview]
Message-ID: <4E1F018E.2080703@gmail.com> (raw)
In-Reply-To: <1310001388-4084-1-git-send-email-galak@kernel.crashing.org>
Hi Kumar, Wolfgang
On 07/06/2011 09:16 PM, Kumar Gala wrote:
> When booting with a ramdisk we bump the amount of memory reserved for
> the device tree by FDT_RAMDISK_OVERHEAD. However we did not increase
> the actual size in the device tree blob to match.
>
> Its possible on boundary cases that we dont have enough memory according
> to the device tree blob and get errors like:
>
> WARNING: could not set linux,initrd-end FDT_ERR_NOSPACE
>
> We can easily fix this by setting the device tree size at the same time
> we bump the amount of memory reserved for the device tree.
>
> Signed-off-by: Kumar Gala<galak@kernel.crashing.org>
> ---
> arch/powerpc/lib/bootm.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/lib/bootm.c b/arch/powerpc/lib/bootm.c
> index e01787d..4e0cb8f 100644
> --- a/arch/powerpc/lib/bootm.c
> +++ b/arch/powerpc/lib/bootm.c
> @@ -288,8 +288,10 @@ static int boot_body_linux(bootm_headers_t *images)
> return ret;
> of_size = ret;
>
> - if (*initrd_start&& *initrd_end)
> + if (*initrd_start&& *initrd_end) {
> of_size += FDT_RAMDISK_OVERHEAD;
> + fdt_set_totalsize(*of_flat_tree, of_size);
> + }
> /* Create a new LMB reservation */
> lmb_reserve(lmb, (ulong)*of_flat_tree, of_size);
This looks good to me. Since it is in bootm.c and not in libfdt, I'll
let Wolfgang pick it up unless I hear otherwise.
Acked-by: Gerald Van Baren <vanbaren@cideas.com>
Thanks,
gvb
next prev parent reply other threads:[~2011-07-14 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 1:16 [U-Boot] [PATCH] powerpc: Fix device tree padding associated with ramdisk Kumar Gala
2011-07-14 13:30 ` Kumar Gala
2011-07-14 14:47 ` Jerry Van Baren [this message]
2011-07-26 11:55 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1F018E.2080703@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.