From: Jarod Wilson <jarod@redhat.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] [media] imon: rate-limit send_packet spew
Date: Thu, 14 Jul 2011 12:17:24 -0400 [thread overview]
Message-ID: <4E1F1694.4040605@redhat.com> (raw)
In-Reply-To: <4E1F1564.9060502@redhat.com>
Mauro Carvalho Chehab wrote:
> Em 13-07-2011 18:58, Jarod Wilson escreveu:
>> There are folks with flaky imon hardware out there that doesn't always
>> respond to requests to write to their displays for some reason, which
>> can flood logs quickly when something like lcdproc is trying to
>> constantly update the display, so lets rate-limit all that error spew.
>
> This patch caused a compilation error here:
>
> drivers/media/rc/imon.c: In function ‘send_packet’:
> drivers/media/rc/imon.c:519: warning: type defaults to ‘int’ in declaration of ‘DEFINE_RATELIMIT_STATE’
> drivers/media/rc/imon.c:519: warning: parameter names (without types) in function declaration
D'oh, sorry. Missing the <linux/ratelimit.h> #include... Will send a
proper v2 after lunch (and a compile sanity-check).
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2011-07-14 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 21:58 [PATCH] [media] imon: rate-limit send_packet spew Jarod Wilson
2011-07-14 16:12 ` Mauro Carvalho Chehab
2011-07-14 16:17 ` Jarod Wilson [this message]
2011-07-14 17:20 ` [PATCH v2] " Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1F1694.4040605@redhat.com \
--to=jarod@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.