From: "H. Peter Anvin" <hpa@zytor.com>
To: Mike Waychison <mikew@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] x86: Allow disabling of sys_iopl, sys_ioperm
Date: Thu, 14 Jul 2011 15:45:39 -0700 [thread overview]
Message-ID: <4E1F7193.80209@zytor.com> (raw)
In-Reply-To: <CAGTjWtCL-4kqHdQsKHTwCC58y9nqHsJXqxpyygRi3qFvUsqVWw@mail.gmail.com>
On 07/14/2011 03:40 PM, Mike Waychison wrote:
> On Thu, Jul 14, 2011 at 3:35 PM, H. Peter Anvin <hpa@zytor.com> wrote:
>> On 07/14/2011 03:31 PM, Andrew Morton wrote:
>>>
>>> sys_iopl() is missing asmlinkage.
>>>
>>> It would be far more conventional to use cond_syscall(). Perhaps by
>>> adding a CONFIG_X86 area into kernel/sys_ni.c
>>>
>>> fyi, I'm offering special deals on checkpatch.pl site licenses this month.
>>
>> Again, I don't think this makes sense as a compile-time-only option.
>
> echo "enabled" > /proc/sys/kernel/iopl_available
> echo "disabled" > /proc/sys/kernel/iopl_available
> echo "locked" > /proc/sys/kernel/iopl_available
>
I'm suspecting that it might be cleaner to have kernel/ioaccess and
kernel/ioaccess_lock as two booleans (0 or 1)...
-hpa
next prev parent reply other threads:[~2011-07-14 22:46 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-14 20:34 [PATCH 1/2] Kconfig: Allow disabling of CONFIG_DEVPORT Mike Waychison
2011-07-14 20:34 ` [PATCH 2/2] x86: Allow disabling of sys_iopl, sys_ioperm Mike Waychison
2011-07-14 20:37 ` H. Peter Anvin
2011-07-14 20:38 ` Mike Waychison
2011-07-14 20:40 ` H. Peter Anvin
2011-07-18 14:35 ` Jiri Kosina
2011-07-14 22:31 ` Andrew Morton
2011-07-14 22:35 ` H. Peter Anvin
2011-07-14 22:40 ` Mike Waychison
2011-07-14 22:45 ` H. Peter Anvin [this message]
2011-07-14 23:03 ` Alan Cox
2011-07-14 23:04 ` Alan Cox
2011-07-20 19:42 ` Ingo Molnar
2011-07-14 22:42 ` Alan Cox
2011-07-14 22:48 ` Mike Waychison
2011-07-14 23:00 ` Alan Cox
2011-07-14 23:20 ` Mike Waychison
2011-07-14 23:39 ` Alan Cox
2011-07-15 0:48 ` Mike Waychison
2011-07-15 9:55 ` Alan Cox
2011-07-15 18:13 ` Mike Waychison
2011-07-15 18:14 ` H. Peter Anvin
2011-07-15 22:30 ` Andrew G. Morgan
2011-07-15 22:42 ` Mike Waychison
2011-07-17 23:19 ` Eric Paris
2011-07-18 0:04 ` H. Peter Anvin
2011-07-14 21:21 ` [PATCH 1/2] Kconfig: Allow disabling of CONFIG_DEVPORT Greg KH
2011-07-14 22:17 ` Mike Waychison
2011-07-15 6:41 ` Greg KH
2011-07-15 13:13 ` Theodore Tso
2011-07-15 14:51 ` Greg KH
2011-07-15 14:58 ` Alan Cox
2011-07-15 15:19 ` Greg KH
2011-07-15 16:45 ` Mike Waychison
2011-07-15 17:01 ` Greg KH
2011-07-15 17:51 ` Mike Waychison
2011-07-15 18:10 ` H. Peter Anvin
2011-07-15 18:50 ` Andrew Morton
2011-07-15 18:55 ` Ted Ts'o
2011-07-16 7:56 ` Greg KH
2011-07-16 13:05 ` Ted Ts'o
2011-07-16 16:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1F7193.80209@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.