Re: [Qemu-devel] [PATCHv5 10/12] qxl: add QXL_IO_FLUSH_{SURFACES, RELEASE} for guest S3&S4 support

[Gerd Hoffmann <kraxel@redhat.com>]

> +#if SPICE_INTERFACE_QXL_MINOR>= 1
> +    case QXL_IO_FLUSH_RELEASE: {
> +        QXLReleaseRing *ring =&d->ram->release_ring;
> +        if (ring->prod - ring->cons + 1 == ring->num_items) {
> +            fprintf(stderr,
> +                "ERROR: no flush, full release ring [p%d,%dc]\n",
> +                ring->prod, ring->cons);
> +        }
> +        qxl_push_free_res(d, 1 /* flush */);
> +        dprint(d, 1, "QXL_IO_FLUSH_RELEASE exit (%s, s#=%d, res#=%d,%p)\n",
> +            qxl_mode_to_string(d->mode), d->guest_surfaces.count,
> +            d->num_free_res, d->last_release);
> +        break;
> +    }
> +    case QXL_IO_FLUSH_SURFACES_ASYNC:
> +        dprint(d, 1, "QXL_IO_FLUSH_SURFACES_ASYNC (%d) (%s, s#=%d, res#=%d)\n",
> +               val, qxl_mode_to_string(d->mode), d->guest_surfaces.count,
> +               d->num_free_res);
> +        qxl_spice_flush_surfaces_async(d);
> +#endif
> +        break;

The last two lines should be swapped I guess.
Doesn't harm, but looks a bit odd ...

cheers,
   Gerd