From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52377)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QhgUA-0007w5-7U
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 07:23:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QhgU9-0006Cy-0T
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 07:23:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52342)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1QhgU8-0006Cm-Nf
	for qemu-devel@nongnu.org; Fri, 15 Jul 2011 07:23:08 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6FBN6GF018137
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 15 Jul 2011 07:23:06 -0400
Message-ID: <4E202317.3000100@redhat.com>
Date: Fri, 15 Jul 2011 13:23:03 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1310670801-14687-1-git-send-email-alevy@redhat.com>
	<1310670801-14687-10-git-send-email-alevy@redhat.com>
	<4E1FF65E.3040701@redhat.com>
	<20110715090505.GK23682@bow.tlv.redhat.com>
In-Reply-To: <20110715090505.GK23682@bow.tlv.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv5 09/12] qxl: async io support using new
	spice api
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, yhalperi@redhat.com

   Hi,

>>> +        qxl_destroy_primary(d, async);
>>> +#if SPICE_INTERFACE_QXL_MINOR>= 1
>>> +        if (d->mode == QXL_MODE_UNDEFINED&&   async == QXL_ASYNC) {
>>> +            dprint(d, 1, "QXL_IO_DESTROY_PRIMARY_ASYNC in %s, ignored\n",
>>> +                    qxl_mode_to_string(d->mode));
>>> +            qxl_send_events(d, QXL_INTERRUPT_IO_CMD);
>>> +            goto cancel_async;
>>>           }
>>
>> Hmm?  Why this is needed?
> In this case we don't do any operation (i.e. qxl_destroy_primary is a nop,
> it checkes d->mode == QXL_MODE_UNDEFINED too) so there will never be an async_complete,
> so there will never be a qxl_send_events, so we need to send it now.

Ok.  Maybe make qxl_destroy_primary return an error in case there is no 
primary to destroy, then catch this here?  Makes more clear what is 
going on here.

>>
>>>       default:
>>>           fprintf(stderr, "%s: ioport=0x%x, abort()\n", __FUNCTION__, io_port);
>>>           abort();
>>>       }
>>> +    return;
>>> +cancel_async:
>>> +#if SPICE_INTERFACE_QXL_MINOR>= 1
>>> +    if (async) {
>>> +        qemu_mutex_lock(&d->async_lock);
>>> +        d->current_async = QXL_UNDEFINED_IO;
>>> +        qemu_mutex_unlock(&d->async_lock);
>>
>> Add "qxl_send_events(d, QXL_INTERRUPT_IO_CMD)" here?
>
> no, we want that wen the command is actually complete, on async_complete,
> where it is already done.

That is the cancel code path, i.e. the guest did a async request but we 
don't submit one to the spice-server because some sanity check failed, 
so we never get a complete callback.  Thats why I think we should raise 
the QXL_INTERRUPT_IO_CMD interrupt here instead.

cheers,
   Gerd