From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [PATCH] Fix xencommons for NetBSD
Date: Fri, 15 Jul 2011 13:37:37 +0200
Message-ID: <4E202681.1040302@amd.com>
References: <CAPLaKK7siKth90wyjh465CVnmbDhFMZs3tLe_=fhuOjy2CmANQ@mail.gmail.com>	<1310716893.634.552.camel@zakaz.uk.xensource.com>	<4E200171.5080700@amd.com>	<1310721214.634.561.camel@zakaz.uk.xensource.com>	<CAPLaKK5vbmF2GdDM1xz3R7-5+OMVTomaUv5zey0oYob=kVsDdg@mail.gmail.com>	<1310722858.634.573.camel@zakaz.uk.xensource.com>	<CAPLaKK4dLuUfjsxPohcArTRV+eV6RU2ARqAHGkyy6bZL_c2BWQ@mail.gmail.com>	<1310724488.634.577.camel@zakaz.uk.xensource.com>
	<CAPLaKK5Q4T39NFUT5g91L9p7Sj5oKg8zKPVs+QaqwBKqBPQ7dg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <CAPLaKK5Q4T39NFUT5g91L9p7Sj5oKg8zKPVs+QaqwBKqBPQ7dg@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@entel.upc.edu>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 07/15/11 13:27, Roger Pau Monn=C3=A9 wrote:
> Another one, used -n instead of -z when testing the presence of
> XENSTORED_ROOTDIR. Sorry for this mess, I'm not really used to make
> shell init scripts.

This version is good.

Acked-by: Christoph Egger <Christoph.Egger@amd.com>

>
> Regards, Roger.
>
> 2011/7/15 Ian Campbell<Ian.Campbell@eu.citrix.com>:
>> On Fri, 2011-07-15 at 10:55 +0100, Roger Pau Monn=C3=A9 wrote:
>>> Just a minor fix,&>/dev/null used with rm puts the process in the
>>> background, so xenstore might be started before the database was
>>> cleaned.
>>
>> Oh right, because&>/dev/null is a bash-ism.
>>
>>>
>>> Regards, Roger.
>>>
>>> 2011/7/15 Ian Campbell<Ian.Campbell@eu.citrix.com>:
>>>> On Fri, 2011-07-15 at 10:18 +0100, Roger Pau Monn=C3=A9 wrote:
>>>>> Thanks for the comments, here is the new patch, changed the commit
>>>>> message and used the method found on Linux script to wait for xenst=
ore
>>>>> to come up.
>>>>
>>>> Looks good to me in the general sense, although I can't comment on t=
he
>>>> NetBSD specifics.
>>>>
>>>> Acked-by: Ian Campbell<ian.campbell@citrix.com>



--=20
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632