From: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
To: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>,
Collin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 2/3] ARM: tegra: paz00: export the WIFI rfkill gpio
Date: Fri, 15 Jul 2011 21:25:00 +0400 [thread overview]
Message-ID: <4E2077EC.1070902@ru.mvista.com> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF049E834C2F-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
Hello.
Stephen Warren wrote:
>> This makes the WIFI rfkill gpio available to userspace. On boot,
>> WIFI will be unblocked by default.
> ...
>> +static void __init paz00_wifi_init(void)
>> +{
>> + int ret;
>> +
>> + /* unlock hw rfkill */
>> + ret = gpio_request_one(TEGRA_WIFI_PWRN, GPIOF_OUT_INIT_HIGH,
>> + "wifi pwrn");
>> + if (ret) {
>> + pr_warning("WIFI: could not requestrfkill gpio\n");
>> + return;
>> + }
>> + gpio_export(TEGRA_WIFI_PWRN, 0);
>> +};
>
> Wouldn't you want to skip the gpio_export() call if the gpio_request()
> call failed?
I think that's what he does -- there's a *return* statement.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: tegra: paz00: export the WIFI rfkill gpio
Date: Fri, 15 Jul 2011 21:25:00 +0400 [thread overview]
Message-ID: <4E2077EC.1070902@ru.mvista.com> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF049E834C2F@HQMAIL01.nvidia.com>
Hello.
Stephen Warren wrote:
>> This makes the WIFI rfkill gpio available to userspace. On boot,
>> WIFI will be unblocked by default.
> ...
>> +static void __init paz00_wifi_init(void)
>> +{
>> + int ret;
>> +
>> + /* unlock hw rfkill */
>> + ret = gpio_request_one(TEGRA_WIFI_PWRN, GPIOF_OUT_INIT_HIGH,
>> + "wifi pwrn");
>> + if (ret) {
>> + pr_warning("WIFI: could not requestrfkill gpio\n");
>> + return;
>> + }
>> + gpio_export(TEGRA_WIFI_PWRN, 0);
>> +};
>
> Wouldn't you want to skip the gpio_export() call if the gpio_request()
> call failed?
I think that's what he does -- there's a *return* statement.
WBR, Sergei
next prev parent reply other threads:[~2011-07-15 17:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 10:24 [PATCH 0/3] ARM: tegra: paz00: Add Wifi and second serial port support Marc Dietrich
2011-07-15 10:24 ` Marc Dietrich
[not found] ` <1310725464-2524-1-git-send-email-marvin24-Mmb7MZpHnFY@public.gmane.org>
2011-07-15 10:24 ` [PATCH 1/3] ARM: tegra: paz00: add support serial port on JP1 Marc Dietrich
2011-07-15 10:24 ` Marc Dietrich
[not found] ` <1310725464-2524-2-git-send-email-marvin24-Mmb7MZpHnFY@public.gmane.org>
2011-07-15 16:39 ` Stephen Warren
2011-07-15 16:39 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF049E834C23-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-07-16 15:59 ` Marc Dietrich
2011-07-16 15:59 ` Marc Dietrich
2011-07-15 10:24 ` [PATCH 2/3] ARM: tegra: paz00: export the WIFI rfkill gpio Marc Dietrich
2011-07-15 10:24 ` Marc Dietrich
[not found] ` <1310725464-2524-3-git-send-email-marvin24-Mmb7MZpHnFY@public.gmane.org>
2011-07-15 12:17 ` Vasily Khoruzhick
2011-07-15 12:17 ` Vasily Khoruzhick
[not found] ` <201107151517.03176.anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2011-07-22 20:38 ` Marc Dietrich
2011-07-22 20:38 ` Marc Dietrich
2011-07-15 16:53 ` Stephen Warren
2011-07-15 16:53 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF049E834C2F-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-07-15 17:25 ` Sergei Shtylyov [this message]
2011-07-15 17:25 ` Sergei Shtylyov
[not found] ` <4E2077EC.1070902-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2011-07-15 17:30 ` Stephen Warren
2011-07-15 17:30 ` Stephen Warren
2011-07-15 10:24 ` [PATCH 3/3] ARM: tegra: paz00: enable wifi led Marc Dietrich
2011-07-15 10:24 ` Marc Dietrich
[not found] ` <1310725464-2524-4-git-send-email-marvin24-Mmb7MZpHnFY@public.gmane.org>
2011-07-15 17:10 ` Stephen Warren
2011-07-15 17:10 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF049E834C43-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-07-16 16:19 ` Marc Dietrich
2011-07-16 16:19 ` Marc Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2077EC.1070902@ru.mvista.com \
--to=sshtylyov-igf4poytycdqt0dzr+alfa@public.gmane.org \
--cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marvin24-Mmb7MZpHnFY@public.gmane.org \
--cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.