Re: [PATCH 02/07] dccp: support for exchanging of NN options in established

[Samuel Jero <sj323707@ohio.edu>]

[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]

You have my Signed-off-by for this patch. I would recommend making a
minor change in one of the comments. See below.

On 07/14/2011 09:42 AM, Gerrit Renker wrote:
> This patch provides support for the reception of NN options in (PART)OPEN state.
> It is a combination of change_recv() and confirm_recv(), specifically geared
> towards receiving the `fast-path' NN options.
> 
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
> Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>

Signed-off-by: Samuel Jero <sj323707@ohio.edu>

>   * dccp_feat_parse_options  -  Process Feature-Negotiation Options
>   * @sk: for general use and used by the client during connection setup
>   * @dreq: used by the server during connection setup
> @@ -1286,6 +1394,15 @@ int dccp_feat_parse_options(struct sock *sk, struct dccp_request_sock *dreq,
>  			return dccp_feat_confirm_recv(fn, mandatory, opt, feat,
>  						      val, len, server);
>  		}
> +		break;
> +	/*
> +	 *	Support for exchanging NN options on an established connection
> +	 *	This is currently restricted to Ack Ratio (RFC 4341, 6.1.2)
> +	 */

This comment is out of date. We now process Sequence Window updates
dynamically. I would remove the second line.

> +	case DCCP_OPEN:
> +	case DCCP_PARTOPEN:
> +		return dccp_feat_handle_nn_established(sk, mandatory, opt, feat,
> +						       val, len);
>  	}
>  	return 0;	/* ignore FN options in all other states */
>  }



Samuel Jero
Internetworking Research Group
Ohio University


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]