All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Scharsig <js_at_ng@scharsoft.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix: if using crc32 command watchdog timed out
Date: Sun, 17 Jul 2011 08:25:33 +0200	[thread overview]
Message-ID: <4E22805D.1010408@scharsoft.de> (raw)
In-Reply-To: <4E215FA2.6030007@aribaud.net>

Hello,
Am 2011-07-16 11:53, schrieb Albert ARIBAUD:
> Hi Jens,
> 
> Le 05/07/2011 09:26, Jens Scharsig a ?crit :
> 
>> * Fix: if using crc32 command watchdog timed out
>>
>>
>> Signed-off-by: Jens Scharsig<esw@bus-elektronik.de>
>> ---
> 
> Nitpick: in addition to describing which issue the patch fixes, can you 
> describe how it fixes it?

If your board is using a watchdog and you try to calculate/check a CRC2
with crc32 command, the watchdog timed out on large data blocks.
The commands around uboot-images also uses crc32, but don't time out.
The difference between:

CRC32 command calls the the crc32 function and the"image" commands
crc32_wd (i think _wd stands for watchdog). So this patch changes the
the function call from crc32 to crc_32 to support watchdog reset in  the
same way as "image" commands.

Best regards

Jens

  reply	other threads:[~2011-07-17  6:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05  7:26 [U-Boot] [PATCH] Fix: if using crc32 command watchdog timed out Jens Scharsig
2011-07-16  9:53 ` Albert ARIBAUD
2011-07-17  6:25   ` Jens Scharsig [this message]
2011-07-17  9:18     ` Albert ARIBAUD
2011-07-18  6:31 ` [U-Boot] [PATCH V2] " Jens Scharsig
2011-07-18  6:42   ` Albert ARIBAUD
2011-07-18  6:46 ` [U-Boot] [PATCH V3] " Jens Scharsig
2011-07-25 22:41   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E22805D.1010408@scharsoft.de \
    --to=js_at_ng@scharsoft.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.